Repository navigation
Fix Windows desktop window controls with native decorations - #2588
Closed
PabloValencia14 wants to merge 1 commit into
Closed
PabloValencia14 wants to merge 1 commit into
PabloValencia14 wants to merge 1 commit into
Conversation
|
Thanks for the PR! Please complete the pull request template — in particular the checkbox confirming you wrote or personally reviewed every line, and the issue this change addresses. It helps us tell real contributions from the flood of auto-generated ones. Edit your PR description; no need to open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #2589
On Windows, the main window was transparent and undecorated, using macOS-like custom controls and manual dragging. Existing VM probing limited the native fallback. This change uses a native, opaque, decorated main window on Windows, preserves the Linux native frame and canvas workaround and macOS custom chrome, removes obsolete Windows VM shell probes, keeps chrome visibility and rounded clipping consistent, and updates screen-height guidance and minimal Windows launch documentation.
Linked issue
Closes #2589
Checklist
:desktopApp:compileKotlinJvmpassed; launched the actual desktop app and confirmed the UI and functionality; exercised native window/client geometry and DPI transitions across three displays at 96, 120, and another differing DPI, including resize, maximize, and restore. No Android testing. Rendered Compose pixels were not individually checked. AI assistance was used; I personally reviewed every line of this change.