Skip to content

Minor fixes - #111

Closed
ocefpaf wants to merge 12 commits into
matplotlib:mainfrom
ocefpaf:minor_fixes
Closed

ocefpaf wants to merge 12 commits into
matplotlib:mainfrom
ocefpaf:minor_fixes

Conversation

@ocefpaf

@ocefpaf ocefpaf commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

I was chasing a red-herring due to a bad pinned version in an environment and ended up adding more Pythons to the test matrix here. No need code, just boilerplate updates.

@kthyng

kthyng commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

@ocefpaf Is some of this the new way to do packaging, in particular removing the setup.* files? Stresses me out. Did you do it correctly?

@ocefpaf

ocefpaf commented Jul 29, 2024

Copy link
Copy Markdown
Contributor Author

@ocefpaf Is some of this the new way to do packaging, in particular removing the setup.* files?

Yes. See https://peps.python.org/pep-0518/ and https://peps.python.org/pep-0517/ for more info. Python packaging rarely requires a setup.py nowadays.

Stresses me out. Did you do it correctly?

Sorry for the stress. Feel free to close it. Regarding correctness. We can add a packaging tests here, build sdist and wheel for upload, to ensure things work.

@kthyng

kthyng commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Sorry for the stress. Feel free to close it. Regarding correctness. We can add a packaging tests here, build sdist and wheel for upload, to ensure things work.

No! That's not what I meant, I meant that I don't feel in a good position to check it and it always feels a bit like magic. You're right, a test would be a good way! And thanks for the resources, I need to keep updating my understanding of how things work.

@ocefpaf

ocefpaf commented Aug 5, 2024

Copy link
Copy Markdown
Contributor Author

You're right, a test would be a good way!

The release GitHub Actions now:

  • checks the sdist
  • checks wheel
  • checks the manifest
  • installs and run the tests for the wheel

That should help avoid any regressions.

Comment thread .github/workflows/release.yaml Outdated
Comment thread .github/workflows/test.yaml Outdated
Comment thread .github/workflows/test.yaml Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to have not posted this somehow.

Comment thread .github/workflows/release.yaml Outdated
Comment thread .github/workflows/release.yaml Outdated
@ocefpaf

ocefpaf commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

If the authors here are interested in any of the changes here feel free to copy them from this PR. Closing it b/c the requests here are beyond the scope of the PR.

@ocefpaf ocefpaf closed this Aug 28, 2026
@ocefpaf
ocefpaf deleted the minor_fixes branch August 28, 2026 20:02

This branch was previously deployed

1 inactive deployment
pypi — 05525aad Deployed Oct 10, 2024 by ocefpaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants