Repository navigation
Minor fixes - #111
Minor fixes#111ocefpaf wants to merge 12 commits into
Conversation
|
@ocefpaf Is some of this the new way to do packaging, in particular removing the setup.* files? Stresses me out. Did you do it correctly? |
Yes. See https://peps.python.org/pep-0518/ and https://peps.python.org/pep-0517/ for more info. Python packaging rarely requires a setup.py nowadays.
Sorry for the stress. Feel free to close it. Regarding correctness. We can add a packaging tests here, build sdist and wheel for upload, to ensure things work. |
No! That's not what I meant, I meant that I don't feel in a good position to check it and it always feels a bit like magic. You're right, a test would be a good way! And thanks for the resources, I need to keep updating my understanding of how things work. |
The release GitHub Actions now:
That should help avoid any regressions. |
QuLogic
left a comment
There was a problem hiding this comment.
I seem to have not posted this somehow.
|
If the authors here are interested in any of the changes here feel free to copy them from this PR. Closing it b/c the requests here are beyond the scope of the PR. |
I was chasing a red-herring due to a bad pinned version in an environment and ended up adding more Pythons to the test matrix here. No need code, just boilerplate updates.