Skip to content

Fix live RCB CID identity and streamline export feedback - #75

Merged
masarray merged 5 commits into
mainfrom
fix/rcb-export-identity-and-flow
Jul 20, 2026
Merged

Fix live RCB CID identity and streamline export feedback#75
masarray merged 5 commits into
mainfrom
fix/rcb-export-identity-and-flow

Conversation

@masarray

Copy link
Copy Markdown
Owner

Reported problems

  • successful RCB export used a native MessageBox outside the application's visual language;
  • live CID export treated an MMS Logical Device domain such as OCR7SJ8Application as the physical IED name, while the actual IED is OCR7SJ8Mod2;
  • the resulting identity/reference mismatch can prevent a SAS tool from associating with the intended IED;
  • opening RCB Export required a second manual click before availability was checked and gave weak feedback during the network audit.

Application changes

  • opening a production RCB Export window automatically starts the existing read-only availability audit;
  • show a centered non-blocking wait overlay with indeterminate progress and explicit no-write/no-reservation text;
  • preserve the manual Check Availability button for refresh/retry;
  • replace the successful-export MessageBox with an in-window success card;
  • success card fades in, shows file/schema/RCB counts, and dismisses itself after three seconds;
  • stop opening Explorer automatically after export so the engineering window keeps focus;
  • use AuthoritativeLiveIedSclExporter for live selected-RCB CID output;
  • pass device.Name as IedNameOverride, while retaining original MMS Logical Device domain names through the engine identity normalizer.

Safety and scope

  • availability remains read-only;
  • no RCB is reserved, enabled, or modified by the audit;
  • source SCL remains immutable;
  • exactly one RCB remains required;
  • Edition 1 remains the default legacy SAS export profile;
  • warning/error confirmation behavior remains explicit; only the success dialog is replaced.

Regression gates

The RCB guard now rejects:

  • bypassing authoritative identity normalization;
  • missing device.Name override;
  • missing automatic availability audit or progress animation;
  • reintroduction of the native success MessageBox;
  • success overlays that do not auto-dismiss after three seconds;
  • loss of the engine's explicit MMS-domain validation.

@masarray
masarray marked this pull request as ready for review July 20, 2026 07:47
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit dbbe4a7 into main Jul 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant