Fix live RCB CID identity and streamline export feedback - #75
Merged
Conversation
masarray
marked this pull request as ready for review
July 20, 2026 07:47
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported problems
OCR7SJ8Applicationas the physical IED name, while the actual IED isOCR7SJ8Mod2;Application changes
AuthoritativeLiveIedSclExporterfor live selected-RCB CID output;device.NameasIedNameOverride, while retaining original MMS Logical Device domain names through the engine identity normalizer.Safety and scope
Regression gates
The RCB guard now rejects:
device.Nameoverride;