Skip to content

Reduce P1 workspace noise and progressive GOOSE disclosure - #205

Merged
masarray merged 13 commits into
mainfrom
polish/p1-workspace-noise-cleanup
Aug 17, 2026
Merged

Reduce P1 workspace noise and progressive GOOSE disclosure#205
masarray merged 13 commits into
mainfrom
polish/p1-workspace-noise-cleanup

Conversation

@masarray

@masarray masarray commented Aug 17, 2026

Copy link
Copy Markdown
Owner

P1 — Workspace Noise Cleanup

Presentation-focused cleanup to improve signal-to-operator across Event Log, Diagnostics, Alarm, and GOOSE without changing IEC 61850 runtime semantics.

Scope

  • Event Log separates process-state presentation from IEC 61850 Quality attention. Quality now uses a contained neutral/amber/red badge instead of competing with process-value state color.
  • Diagnostics removes whole-cell WARN/ERROR tinting. Severity is contained to a level badge plus a slim left rail so message content remains readable and the table stays calm.
  • Alarm replaces cryptic microcopy with readable operational wording, removes redundant Select fascia copy, and raises sub-10 px operational labels to a more legible size while preserving all latched alarm state colors and ACK behavior.
  • GOOSE idle state uses progressive disclosure: adapter + Start + capture status stay primary; BPF/model-binding controls move into a collapsed Capture options expander; Stop replaces Start while capturing; Clear appears only when streams exist; DataSet inspector is hidden until a stream is selected.

Safety boundary

This PR does not modify Services/*, IEC 61850 acquisition/reporting, RCB planning, SOE/event semantics, Smart Control behavior, Alarm state machine, GOOSE capture/parser semantics, or the ARIEC61850 engine lock. Engine remains pinned to becda399b4a3ae34831215fc915798b4f846c1be from source PR #81.

Regression coverage

Adds WorkspaceNoiseP1RegressionTests covering IEC Quality presentation tones, Event Log separation of state/quality, contained Diagnostics severity, Alarm microcopy/legibility, GOOSE progressive disclosure, and the immutable engine pin. Two existing presentation tests were updated only to replace obsolete literal wording guards with the new P1 semantic wording.

Verification

Exact head f61e1f9b9dc374e055e0d1f4a09b130c54ef3f1b passes Build ARSAS #1242, all 381 regression tests, SV evidence #374, Legacy SAS RCB guard #89, portable single-EXE publish, and portable startup smoke.

Temporary inspection/patch tooling was removed before merge. Final diff contains five production/presentation/test source files plus two existing regression-test wording updates.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit 46e7dea into main Aug 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant