Reduce P1 workspace noise and progressive GOOSE disclosure - #205
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 — Workspace Noise Cleanup
Presentation-focused cleanup to improve signal-to-operator across Event Log, Diagnostics, Alarm, and GOOSE without changing IEC 61850 runtime semantics.
Scope
Select fasciacopy, and raises sub-10 px operational labels to a more legible size while preserving all latched alarm state colors and ACK behavior.Capture optionsexpander; Stop replaces Start while capturing; Clear appears only when streams exist; DataSet inspector is hidden until a stream is selected.Safety boundary
This PR does not modify
Services/*, IEC 61850 acquisition/reporting, RCB planning, SOE/event semantics, Smart Control behavior, Alarm state machine, GOOSE capture/parser semantics, or the ARIEC61850 engine lock. Engine remains pinned tobecda399b4a3ae34831215fc915798b4f846c1befrom source PR #81.Regression coverage
Adds
WorkspaceNoiseP1RegressionTestscovering IEC Quality presentation tones, Event Log separation of state/quality, contained Diagnostics severity, Alarm microcopy/legibility, GOOSE progressive disclosure, and the immutable engine pin. Two existing presentation tests were updated only to replace obsolete literal wording guards with the new P1 semantic wording.Verification
Exact head
f61e1f9b9dc374e055e0d1f4a09b130c54ef3f1bpasses Build ARSAS #1242, all 381 regression tests, SV evidence #374, Legacy SAS RCB guard #89, portable single-EXE publish, and portable startup smoke.Temporary inspection/patch tooling was removed before merge. Final diff contains five production/presentation/test source files plus two existing regression-test wording updates.