Fix hybrid reconnect and evidence snapshot races - #178
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 306ca05b03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var plans = await BuildReportPlansForCurrentAssociationAsync( | ||
| session, | ||
| legacyPlans, | ||
| cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
Reset per-point report evidence before rebuilding plans
When a point had ReportChangeVerified set before the connection dropped, this reconnect path resets the hybrid tracker but leaves that flag and ReportTrafficSeen intact in session.States. The first GI or integrity update from the newly started plan is therefore included by ReceiveReportSlicesAsync in verifiedReportPointKeys, causing the fresh validation snapshot to claim a change-verified point even though no change has occurred on the new association. Clear the per-association report evidence flags before starting these rebuilt plans so reconnects cannot produce false physical-validation evidence.
Useful? React with 👍 / 👎.
306ca05 to
ea679c2
Compare
Summary
Addresses
Validation