Skip to content

Fix hybrid reconnect and evidence snapshot races - #178

Merged
masarray merged 1 commit into
mainfrom
agent/fix-hybrid-reconnect-snapshot
Aug 15, 2026
Merged

Fix hybrid reconnect and evidence snapshot races#178
masarray merged 1 commit into
mainfrom
agent/fix-hybrid-reconnect-snapshot

Conversation

@masarray

Copy link
Copy Markdown
Owner

Summary

  • reuse the same ARIEC-authoritative hybrid planning pipeline after MMS reconnect, including fresh RCB availability revalidation
  • synchronize planning, activation, report-slice mutation, warning de-duplication, and snapshot capture in the physical-validation tracker
  • prepare patch release v1.6.31 because these review findings arrived after v1.6.30 publication

Addresses

Validation

  • 6/6 focused hybrid physical-validation/reconnect tests passed
  • 241/241 ARSAS tests passed against pinned ARIEC61850 commit 32351b42b4719e5dccfa068fbbd797c2414a6b4b
  • concurrency regression executes 1,000 interleaved reset/activation/slice/capture operations and checks aggregate snapshot consistency
  • source-clean gate passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 306ca05b03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1434 to +1437
var plans = await BuildReportPlansForCurrentAssociationAsync(
session,
legacyPlans,
cancellationToken).ConfigureAwait(false);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reset per-point report evidence before rebuilding plans

When a point had ReportChangeVerified set before the connection dropped, this reconnect path resets the hybrid tracker but leaves that flag and ReportTrafficSeen intact in session.States. The first GI or integrity update from the newly started plan is therefore included by ReceiveReportSlicesAsync in verifiedReportPointKeys, causing the fresh validation snapshot to claim a change-verified point even though no change has occurred on the new association. Clear the per-association report evidence flags before starting these rebuilt plans so reconnects cannot produce false physical-validation evidence.

Useful? React with 👍 / 👎.

@masarray
masarray force-pushed the agent/fix-hybrid-reconnect-snapshot branch from 306ca05 to ea679c2 Compare August 14, 2026 23:58
@masarray
masarray merged commit 6b22ab7 into main Aug 15, 2026
3 checks passed
@masarray
masarray deleted the agent/fix-hybrid-reconnect-snapshot branch August 15, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant