Repository navigation
fix: keep lazy setext underlines in list items as text - #4126
Open
vhinayindia wants to merge 1 commit into
Open
vhinayindia wants to merge 1 commit into
vhinayindia wants to merge 1 commit into
Conversation
|
@vhinayindia is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version:
18.1.0Markdown flavor: CommonMark
Description
CommonMark 0.31.2 §4.3 says a setext underline cannot be a lazy continuation line in a list item. For example:
Marked currently treats
===as an underline and emits a heading. After the list tokenizer removes the item's indentation, the lazy line can incorrectly match the setext rule.Keep an under-indented setext-looking continuation as paragraph text in this case, while preserving correctly indented setext headings. The regression fixtures cover both underline levels, zero and partial indentation, prior continuation text, and nested lists. PR #4119 addresses list tab-stop expansion; this change covers the separate setext parsing behavior.
Contributor
Verification
npm testpassed, including docs build, spec suite, 193 unit tests, UMD/CJS, type/export checks, and ESLint.Committer