Skip to content
This repository was archived by the owner on Apr 3, 2026. It is now read-only.

Fix project draft topic save - #958

Merged
tnagorra merged 5 commits into
devfrom
fix/project-draft-topic
Jul 31, 2024
Merged

Fix project draft topic save#958
tnagorra merged 5 commits into
devfrom
fix/project-draft-topic

Conversation

@puranban

@puranban puranban commented Jul 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Fix condition to compare project title unique and save to draft
  • Remove multiple space from project topic
  • Cloud function
    • Change username to lowercase and remove space
    • Change project topuc to lowercase and change multiples space to single

@puranban
puranban force-pushed the fix/project-draft-topic branch from c8c0303 to 90d6913 Compare July 29, 2024 07:16
@puranban
puranban marked this pull request as ready for review July 29, 2024 08:35
@puranban
puranban requested a review from tnagorra July 29, 2024 08:35
@tnagorra
tnagorra changed the base branch from dev to master July 29, 2024 09:03
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread manager-dashboard/app/views/NewProject/index.tsx Outdated
tnagorra
tnagorra reviewed Jul 29, 2024
View reviewed changes
Comment thread manager-dashboard/app/views/NewProject/index.tsx
@puranban
puranban requested a review from tnagorra July 30, 2024 08:23
tnagorra
tnagorra reviewed Jul 30, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 30, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 30, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 30, 2024
View reviewed changes
Comment thread firebase/functions/src/utils/index.ts Outdated
tnagorra
tnagorra reviewed Jul 30, 2024
View reviewed changes
Comment thread manager-dashboard/app/utils/common.tsx Outdated
@puranban
puranban force-pushed the fix/project-draft-topic branch from 0fd4085 to 0e9fadd Compare July 30, 2024 09:55
@puranban
puranban requested a review from tnagorra July 30, 2024 09:59
tnagorra
tnagorra reviewed Jul 30, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
tnagorra
tnagorra reviewed Jul 30, 2024
View reviewed changes
Comment thread firebase/functions/src/index.ts Outdated
@puranban
puranban force-pushed the fix/project-draft-topic branch 2 times, most recently from 616c37f to bd968fa Compare July 30, 2024 11:00
@puranban
puranban requested a review from tnagorra July 30, 2024 11:00
tnagorra
tnagorra reviewed Jul 30, 2024
View reviewed changes
Comment thread firebase/database.rules.json Outdated
tnagorra
tnagorra reviewed Jul 30, 2024
View reviewed changes
Comment thread firebase/functions/src/utils/index.ts Outdated
@puranban
puranban force-pushed the fix/project-draft-topic branch from bd968fa to c4f9056 Compare July 31, 2024 07:50
@puranban
puranban requested a review from tnagorra July 31, 2024 07:51
@puranban
puranban force-pushed the fix/project-draft-topic branch 2 times, most recently from 7d79952 to d928e51 Compare July 31, 2024 08:39
@puranban
puranban force-pushed the fix/project-draft-topic branch from d928e51 to 30a6b57 Compare July 31, 2024 08:40
@tnagorra
tnagorra changed the base branch from master to dev July 31, 2024 09:05
@tnagorra
tnagorra merged commit 0c3fcde into dev Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@frozenhelium frozenhelium Awaiting requested review from frozenhelium
@samshara samshara Awaiting requested review from samshara
1 more reviewer
@tnagorra tnagorra tnagorra approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tnagorra tnagorra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@puranban @tnagorra @frozenhelium @samshara @thenav56