Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Local staging/review draft in the fork only. Upstream contribution guidelines require an issue before any PR.
Targeted at the maintained v1.x router-support line. This is the v1.x port of draft #5.
Summary
Make DHCP client discovery pick up dnsmasq lease files which appear after ctrld starts, including Asuswrt-Merlin 3006 Guest Network Pro / SDN instances.
/var/lib/misclease directory;dnsmasq-*.leasesfiles;Relation to Merlin SDN
The DNS hook work in #7 fixes forwarding for Guest Network Pro. This draft fixes the separate DHCP/client-discovery lifecycle so SDN leases can also appear after ctrld startup.