Conversation
JayDi85
requested changes
Sep 28, 2026
|
|
||
| private final Iterator<MageObjectReferencePredicate> newTargetTypes; | ||
|
|
||
| private ForEachCopyApplier(List<MageObjectReferencePredicate> copiesWithTargets) { |
Member
There was a problem hiding this comment.
why it was copy pasted instead CopySpellForEachItCouldTargetEffect usage?
| @Override | ||
| public boolean apply(Game game, Ability source) { | ||
| Player player = game.getPlayer(source.getControllerId()); | ||
| Spell spell = (Spell) getValue("triggeringSpell"); |
Member
There was a problem hiding this comment.
Looks like a wrong usage. Copy paste instead extends of CopySpellForEachItCouldTargetEffect -- look at other cards with same style like ZadaHedronGrinder and others. Search by (Spell) getValue("triggeringSpell")
| addTarget(playerA, "Grizzly Bears^Silvercoat Lion"); | ||
|
|
||
| setStopAt(1, PhaseStep.BEGIN_COMBAT); | ||
| execute(); |
brahle
force-pushed
the
feat/mkc-feather-radiant-arbiter
branch
from
September 28, 2026 02:14
9e2f70f to
4c187ff
Compare
Author
|
Thank you for the review. I've used the appropriate class now - the code is updated. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing Feather, Radiant Arbiter for the MKC set #11669