Conversation
After the expanded composer hits its max height, typing no longer scrolled the current line into view, so long prompts were entered blind. Grow the editor from the native content-size event up to that cap and call bringPointIntoView after text, selection, and layout updates.
|
@coderabbitai run pre-merge checks |
One-line JSDoc/TSDoc/KDoc on functions touched by the caret-into-view change so CodeRabbit docstring coverage can meet the 80% threshold. Co-authored-by: maco <macodev00@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/android-composer-caret-scroll-0ab8
branch
from
September 20, 2026 10:38
505ff8e to
1084569
Compare
Extract leftover anonymous paste/focus/touch callbacks into named functions with one-line JSDoc/KDoc, and put KDoc above @Suppress so CodeRabbit can attach it. Covers the functions the 69% docstring check still treated as undocumented. Co-authored-by: maco <macodev00@users.noreply.github.com>
Controlled document updates can include the current selection without moving it. Scrolling on those resets a manual review scroll. Track whether applySelection changed the range and only bring the caret into view when the text or that range actually changed. Co-authored-by: maco <macodev00@users.noreply.github.com>
github-actions
Bot
added
size:L
vouch:trusted
|
@coderabbitai review |
Owner
Author
|
Superseded by upstream pingdotgg#12716 — closing fork-local draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pingdotgg#12690.
What Changed
On Android, a long multi-line composer prompt no longer leaves the current line off-screen while typing.
onComposerContentSizeChangeevent (min 72, max 160). Collapsed composers still use a fixed height.bringPointIntoViewso the caret stays visible once that max height is reached. Echo re-renders that only refresh chip spans do not steal a manual scroll.Thread composer and new-task composer share this editor, so both pick up the same behavior. Web already follows the caret via Tiptap
scrollIntoView; this change is Android native.Why
The reporter confirmed the box caps at max height, then typing continues off-screen. Yoga needs a concrete
heightto grow pastminHeight, and Android had no caret-into-view call after controlled text/selection updates (setScrollEnabledonly toggles the scrollbar).UI Changes
Android native composer. No screenshots: this needs a device or emulator, and caret-follow is an interaction, not a static layout change.
Checklist