Skip to content

fix(web): close Run on picker after selecting a machine #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
macodev00 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(web): close Run on picker after selecting a machine #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/web/src/components/BranchToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ const MobileRunContextSelector = memo(function MobileRunContextSelector({
<MenuRadioItem
value="auto"
disabled={envLocked}
closeOnClick
onClick={() => {
if (autoEnvironmentLabel) onAutoEnvironment?.();
}}
Expand All @@ -250,6 +251,7 @@ const MobileRunContextSelector = memo(function MobileRunContextSelector({
key={env.environmentId}
disabled={envLocked}
value={env.environmentId}
closeOnClick
>
<span className="flex min-w-0 items-center gap-1.5">
<EnvironmentMachineIcon kind={env.machine} className="size-3" />
Expand All @@ -274,7 +276,7 @@ const MobileRunContextSelector = memo(function MobileRunContextSelector({
onEnvModeChange(value as EnvMode);
}}
>
<MenuRadioItem disabled={envModeLocked || forceNewWorktree} value="local">
<MenuRadioItem disabled={envModeLocked || forceNewWorktree} value="local" closeOnClick>
<span className="flex min-w-0 items-center gap-1.5">
{activeWorktreePath ? (
<FolderGitIcon className="size-3" />
Expand All @@ -286,14 +288,14 @@ const MobileRunContextSelector = memo(function MobileRunContextSelector({
</span>
</span>
</MenuRadioItem>
<MenuRadioItem disabled={envModeLocked} value="worktree">
<MenuRadioItem disabled={envModeLocked} value="worktree" closeOnClick>
<span className="flex min-w-0 items-center gap-1.5">
<FolderGit2Icon className="size-3" />
<span className="min-w-0 truncate">{resolveEnvModeLabel("worktree")}</span>
</span>
</MenuRadioItem>
{previousWorktreeLabel ? (
<MenuRadioItem disabled={envModeLocked} value="previous-worktree">
<MenuRadioItem disabled={envModeLocked} value="previous-worktree" closeOnClick>
<span className="flex min-w-0 items-center gap-1.5">
<HistoryIcon className="size-3" />
<span className="min-w-0 truncate">{previousWorktreeLabel}</span>
Expand Down