Skip to content

Fix include dir & version - #582

Merged
bsergean merged 1 commit into
machinezone:masterfrom
xiaozhuai:master
Jun 25, 2026
Merged

bsergean merged 1 commit into
machinezone:masterfrom
xiaozhuai:master

Conversation

@xiaozhuai

Copy link
Copy Markdown
Contributor

@BillyONeal

BillyONeal commented Jun 8, 2026 •

Copy link
Copy Markdown

Repeating the content behind the link. @xiaozhuai filed a PR to update the vcpkg port and in that PR, GPT 5.4 found the following. (It did not write anything in this response)

The installed .pc file still claims that this is 11.4.6 despite this claiming to be 12.0.0.

project(ixwebsocket LANGUAGES C CXX VERSION 11.4.6)

The installed CMake and pkgconfig bindings appear to be inconsistent. share\ixwebsocket\ixwebsocket-targets.cmake has:

set_target_properties(ixwebsocket::ixwebsocket PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "IXWEBSOCKET_USE_TLS;IXWEBSOCKET_USE_MBED_TLS;IXWEBSOCKET_USE_ZLIB"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/ixwebsocket"

but lib\pkgconfig\ixwebsocket.pc has:

prefix=${pcfiledir}/../..
includedir=${prefix}/include
Cflags: "-I${includedir}"

This means that the CMake bindings want the user to say, for example, #include <IXUuid.h>, but the pkgconfig bindings want the user to say #include <ixwebsocket/IXUuid.h>.

#include <ixwebsocket/IXUrlParser.h>
looks like the intent is for the .pc to be correct. This PR fixes both of those problems (though likely you will want 12.0.1 or something so that you don't mutate an existing "release")

@bsergean

Copy link
Copy Markdown
Collaborator

Thanks @BillyONeal will try to get that fixed today. Changing the cmake include path worries me a bit.

@bsergean
bsergean merged commit ae949ac into machinezone:master Jun 25, 2026
@bsergean bsergean mentioned this pull request Jun 25, 2026
bsergean added a commit that referenced this pull request Jun 25, 2026
Release of accumulated fixes since v12.0.0: DNS lookup crash/offline
resolution (#589), OpenSSL IP-address cert validation (#588),
case-insensitive Upgrade header (#584), server fd double-close (#585),
fragment buffering optimization (#562), and the install include-dir fix (#582).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants