the client did not receive the close event #474

Activity

1. bsergean commented on Jul 1, 2023

   

   bsergean

   on Jul 1, 2023

   Collaborator

   More actions

   Thanks for the good words, it's possible there are some holes in the IXNetSystem::poll.

   If you want to submit a PR we can try to evaluate it and merge it.

   I code on macOS and Linux, so I'm not the best person to fix advanced windows problem sadly.
2. dacap commented on Aug 22, 2023

   

   dacap

   on Aug 22, 2023

   Contributor

   More actions

   It's probable that there is a missing wakeUpFromPoll() call from WebSocketTransport::close() to unlock the WebSocket::stop() function which is waiting for a _thread.join() (this thread is running WebSocket::run() which calls WebSocketTransport::poll() that can be waken up only if wakeUpFromPoll() is called again):

   diff --git a/ixwebsocket/IXWebSocketTransport.cpp b/ixwebsocket/IXWebSocketTransport.cpp
   index ec25465..8049fb6 100644
   --- a/ixwebsocket/IXWebSocketTransport.cpp
   +++ b/ixwebsocket/IXWebSocketTransport.cpp
   @@ -1174,7 +1174,10 @@ namespace ix
        {
            _requestInitCancellation = true;
    
   -        if (_readyState == ReadyState::CLOSING || _readyState == ReadyState::CLOSED) return;
   +        if (_readyState == ReadyState::CLOSING || _readyState == ReadyState::CLOSED) {
   +            wakeUpFromPoll(SelectInterrupt::kSendRequest);
   +            return;
   +        }
    
            if (closeWireSize == 0)
            {
3. bsergean commented on Aug 23, 2023

   

   bsergean

   on Aug 23, 2023

   Collaborator

   More actions

   @dacap If you make a PR for this change we can give it a try on CI.

   👍React with 👍1Reacted by David Capello
4. dacap

   added 3 commits that reference this issue on Aug 23, 2023

   Fix hanging of WebSocket::stop() waiting for its thread to join

   ...

   80ec49b

   Fix hanging of WebSocket::stop() waiting for its thread to join

   ...

   1f5d729

   Fix hanging of WebSocket::stop() waiting for its thread to join

   ...

   08668a0
5. bsergean

   added a commit that references this issue on Sep 1, 2023

   Fix hanging of WebSocket::stop() waiting for its thread to join (#481)

   ...

   ef57e3a
6. Longwater1234 commented on Jul 9, 2024

   

   Longwater1234

   on Jul 9, 2024

   More actions

   This problem still persists even with latest version. Only on Windows. On MacOS it alright.
7. bsergean commented on May 14, 2025

   

   bsergean

   on May 14, 2025

   Collaborator

   More actions

   Might be fixed with #548