Skip to content

adapters/kafkastreamer: bump testcontainers-go to v0.43.0#199

Open
andrewwormald wants to merge 1 commit into
mainfrom
bump-testcontainers-kafkastreamer
Open

adapters/kafkastreamer: bump testcontainers-go to v0.43.0#199
andrewwormald wants to merge 1 commit into
mainfrom
bump-testcontainers-kafkastreamer

Conversation

@andrewwormald

@andrewwormald andrewwormald commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Bumps testcontainers-go (and the modules/kafka submodule) from v0.35.0 to v0.43.0 in adapters/kafkastreamer.
  • Clears most of the remaining Dependabot alerts rooted in this module's outdated transitive deps: docker/docker and containerd/containerd are replaced by the lighter moby/moby/api + moby/moby/client split, the google.golang.org/grpc dependency is dropped entirely, and go.opentelemetry.io/otel moves to v1.44.0.
  • testcontainers-go is test-only here (spins up a Kafka broker for integration tests) — no change to the adapter's shipped runtime code. go build / go vet are clean.

⚠️ Known issue — needs verification in CI before merge

Locally (Docker via Rancher Desktop), the kafkastreamer integration tests fail after this bump: kafkaInstance.Brokers(ctx) — the testcontainers Kafka module's own documented accessor — returns the container's internal Docker hostname (its container ID) instead of a host-reachable address, so every client connection fails with dial tcp: lookup <container-id>: no such host.

This looks like a testcontainers-go Kafka-module regression in advertised-listener resolution under non-Docker-Desktop container runtimes (see testcontainers/testcontainers-go#2748 for the same class of bug in an earlier version). It may not reproduce under GitHub Actions' standard Docker-in-Docker setup — please confirm the Integration Tests (Testcontainers) CI check passes before merging this one. If it fails in CI too, this bump needs to stay open pending a fix (pin to a testcontainers-go patch version that resolves the listener issue, or adjust how the adapter/tests obtain the broker address).

Test plan

  • go build ./...
  • go vet ./...
  • go test -v -timeout=10m ./...fails locally (see above); pending CI confirmation

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the Kafka streaming adapter’s supporting libraries to newer versions.
    • Improved compatibility with current testing, containerisation, monitoring, compression and system integration tooling.
    • Refreshed underlying OpenTelemetry and Go ecosystem components.

Old testcontainers-go v0.35.0 pulled in outdated github.com/docker/docker,
github.com/containerd/containerd, google.golang.org/grpc, and
go.opentelemetry.io/otel — the source of most of the ~57 open Dependabot
alerts on this repo (many critical). v0.43.0 replaces the docker/containerd
deps with the lighter moby/moby/api + moby/moby/client split, drops the grpc
dependency entirely, and bumps otel to v1.44.0.

go build/go vet are clean. Test-only dependency (testcontainers spins up a
Kafka broker for integration tests); no change to the adapter's runtime code.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5ac52cb1-3783-4ea1-aa12-32f5f31dcd1d

📥 Commits

Reviewing files that changed from the base of the PR and between 2f70c64 and c40b62a.

⛔ Files ignored due to path filters (1)
  • adapters/kafkastreamer/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • adapters/kafkastreamer/go.mod

📝 Walkthrough

Walkthrough

Updated the Kafka streamer Go module’s direct testify and Testcontainers dependencies. Refreshed numerous indirect dependencies across container tooling, compression, Prometheus, OpenTelemetry, and golang.org/x modules, while removing superseded entries and adding newer transitive modules.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

I’m a rabbit with modules to thump,
Fresh versions now hop with a jump.
Test containers align,
Telemetry can shine,
While old dependency carrots go plump.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main change: bumping testcontainers-go in adapters/kafkastreamer.
Description check ✅ Passed The description is directly related to the dependency bump and notes the integration test impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-testcontainers-kafkastreamer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant