adapters/kafkastreamer: bump testcontainers-go to v0.43.0#199
adapters/kafkastreamer: bump testcontainers-go to v0.43.0#199andrewwormald wants to merge 1 commit into
Conversation
Old testcontainers-go v0.35.0 pulled in outdated github.com/docker/docker, github.com/containerd/containerd, google.golang.org/grpc, and go.opentelemetry.io/otel — the source of most of the ~57 open Dependabot alerts on this repo (many critical). v0.43.0 replaces the docker/containerd deps with the lighter moby/moby/api + moby/moby/client split, drops the grpc dependency entirely, and bumps otel to v1.44.0. go build/go vet are clean. Test-only dependency (testcontainers spins up a Kafka broker for integration tests); no change to the adapter's runtime code. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the Kafka streamer Go module’s direct Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Summary
testcontainers-go(and themodules/kafkasubmodule) from v0.35.0 to v0.43.0 inadapters/kafkastreamer.docker/dockerandcontainerd/containerdare replaced by the lightermoby/moby/api+moby/moby/clientsplit, thegoogle.golang.org/grpcdependency is dropped entirely, andgo.opentelemetry.io/otelmoves to v1.44.0.testcontainers-gois test-only here (spins up a Kafka broker for integration tests) — no change to the adapter's shipped runtime code.go build/go vetare clean.Locally (Docker via Rancher Desktop), the kafkastreamer integration tests fail after this bump:
kafkaInstance.Brokers(ctx)— the testcontainers Kafka module's own documented accessor — returns the container's internal Docker hostname (its container ID) instead of a host-reachable address, so every client connection fails withdial tcp: lookup <container-id>: no such host.This looks like a testcontainers-go Kafka-module regression in advertised-listener resolution under non-Docker-Desktop container runtimes (see testcontainers/testcontainers-go#2748 for the same class of bug in an earlier version). It may not reproduce under GitHub Actions' standard Docker-in-Docker setup — please confirm the
Integration Tests (Testcontainers)CI check passes before merging this one. If it fails in CI too, this bump needs to stay open pending a fix (pin to a testcontainers-go patch version that resolves the listener issue, or adjust how the adapter/tests obtain the broker address).Test plan
go build ./...go vet ./...go test -v -timeout=10m ./...— fails locally (see above); pending CI confirmation🤖 Generated with Claude Code
Summary by CodeRabbit