Repository navigation
fix: preserve call function environments in functors - #2
Merged
gvvaughan merged 1 commit intoOct 18, 2026
Merged
Conversation
Prefer a functor's call field over its __call dispatcher when reading or setting its environment. This keeps shared dispatchers unchanged and applies the environment to the function that executes the wrapped code.
This was referenced Oct 16, 2026
Contributor
|
Merged. Looks good, and helps with my trying to get the master branch of lua-stdlib backwards compatible with the release branch. Thanks for contributing @khaneliman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer a callable table's
callfunction over its__calldispatcher when reading or setting its environment. A shared dispatcher delegates toself.call, so changing the dispatcher's environment leaves the wrapped function unchanged and can affect unrelated tables.The regression passes on Lua 5.1 through 5.5 and LuaJIT, with argument checking absent, enabled and disabled. The new Specl examples pass on Lua 5.5; nine other failures in the wider environment group reproduce unchanged on the base revision.