Fix critical bugs: JSON crash, data loss, thread safety, security vulnerabilities - #771
Open
618dt wants to merge 2 commits into
Open
Fix critical bugs: JSON crash, data loss, thread safety, security vulnerabilities#771618dt wants to merge 2 commits into
618dt wants to merge 2 commits into
Conversation
…nerabilities - agent_loop.py: Fix JSONDecodeError crash when LLM returns malformed tool args - ga.py: Fix file_write prepend mode data loss on write failure (atomic write via tmpfile+rename) - ga.py: Fix file handle leaks in code_run, _check_plan_completion - ga.py: Sandboxed inline_eval - remove history exposure, restrict builtins - agentmain.py: Fix thread safety - use self.lock for is_running/stop_sig mutations - agentmain.py: Fix 7 file handle leaks (open without with) - llmcore.py: Fix tryparse unhandled exception on final fallback - ga_ultraplan.py: Add Bearer token auth to /exec HTTP endpoint
…c.compare_digest for auth - ga.py: bare except → except Exception: in atomic write (prevents swallowing KeyboardInterrupt) - ga.py: remove redundant import tempfile (already imported at top) - ga.py: remove setattr from safe_builtins in inline_eval sandbox - ga_ultraplan.py: use hmac.compare_digest() for constant-time token comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #770
Bug Fixes
Critical
High
Medium