Agent guidance around memory lifecycle edges - #1406
Merged
alan-george-lk merged 3 commits intoSep 8, 2026
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
alan-george-lk
force-pushed
the
alan/bugfix-memory-lifecycle-guardrails
branch
from
September 4, 2026 18:16
aba8023 to
b920bc1
Compare
ladvoc
approved these changes
Sep 4, 2026
ladvoc
left a comment
ladvoc
left a comment
Contributor
There was a problem hiding this comment.
Nice! These all seem like good suggestion. My only question is whether we should move the more specific points (e.g. FFI, C++) to separate AGENTS.md files within the related crates to keep the top-level one lean.
alan-george-lk
force-pushed
the
alan/bugfix-memory-lifecycle-guardrails
branch
2 times, most recently
from
September 8, 2026 04:44
ba35b57 to
cee0e54
Compare
Contributor
Changeset ✓This PR includes a changeset covering all affected packages:
|
alan-george-lk
force-pushed
the
alan/bugfix-memory-lifecycle-guardrails
branch
from
September 8, 2026 13:58
1fa787f to
0c56037
Compare
1egoman
added a commit
that referenced
this pull request
Sep 8, 2026
The release page formatting is inconsistient - some entries are changelog bullets, others are `####` headings followed by further markdown. That is knope's rendering rule, not a knope bug. A changeset whose summary is **one line** becomes a bullet: ``` - Add data streams v2 to exposed uniffi interface - #1286 (@1egoman) ``` A summary spanning **more than one line** is promoted to a heading, with everything after the first line dropped below it as loose body text: ``` #### Moves the signalling client into a new `livekit-signaling` crate. livekit-api re-exports it under the historical `livekit_api::signal_client` path, now marked deprecated: ... ``` Markdown blocks (tables, bullet lists, bold-led paragraphs) guarantee this, and they keep showing up in agent-written changesets — but a plain hard line wrap is enough on its own. The changeset for #1406 was plain text wrapped at 80 columns and still rendered as `#### Add agent guidance for detecting and preventing memory-lifecycle regressions in`. So this adds a rule under **Documenting changes** in `AGENTS.md`: write the changeset summary as a single unwrapped line of plain prose, no Markdown blocks (inline backticks are fine — they render correctly), and keep detail in the PR description instead. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
AGENTS.mdguidance around some of the fixes done in this PR stack, to hopefully avoid/catch future regressions.