Video source lifecycle memory fixes - #1400
Merged
alan-george-lk merged 7 commits intoSep 8, 2026
Merged
Conversation
Contributor
Changeset ✓This PR includes a changeset covering all affected packages:
|
alan-george-lk
changed the title
alan-george-lk
marked this pull request as ready for review
September 4, 2026 16:06
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alan-george-lk
force-pushed
the
alan/bugfix-video-source-lifecycle
branch
from
September 4, 2026 18:16
ebcf10b to
41a6073
Compare
ladvoc
approved these changes
Sep 4, 2026
| loop { | ||
| interval.tick().await; | ||
|
|
||
| if !keepalive_should_continue(&captured_frames) { |
Contributor
There was a problem hiding this comment.
note: Not related to changes in this PR, but I wonder what happens if you initially publish some frames (which would kill this task) but later stop publishing frames (e.g., camera temporally goes offline so there are no frames available). This might be the correct logic, but worth verifying with WebRTC.
ladvoc
reviewed
Sep 4, 2026
| break; | ||
| } | ||
|
|
||
| let mut builder = vf_sys::ffi::new_video_frame_builder(); |
Contributor
There was a problem hiding this comment.
note: Also not related to this PR, but this is something we should work to eliminate over time; FFI details between Rust and libwerbtc should not be public API to this layer.
alan-george-lk
force-pushed
the
alan/bugfix-video-source-lifecycle
branch
from
September 7, 2026 23:10
41a6073 to
b583cc1
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
alan-george-lk
force-pushed
the
alan/bugfix-video-source-lifecycle
branch
from
September 8, 2026 13:58
8db24e5 to
d046afd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing