Repository navigation
fix: controller navigation hardening (ported from PR #17) - #47
Merged
Merged
Conversation
- ControllerInput no longer stops polling for good when a pad disconnects mid-read; it skips the sample. IsActive gates reads by window (GetForegroundWindow == hwnd) instead of WinUI activation events. D-pad diagonals count as vertical. - GamepadNavigator: first press only reveals the focus ring; tab-order fallback when the XY search finds nothing in a scrolled list; A on ComboBox/ComboBoxItem/SelectorItem/ToggleSwitch and a Command fallback for SettingsCard; B closes an open ComboBox; Intercept hook. - Desktop interface driven by the pad from MainWindow: Start toggles Settings, B leaves Settings, Y jumps to the console interface, tour A next / B skip. HomeView's ad-hoc listener is gone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the parts of @nextestudios' #17 that our rewrite lacked, on top of the current
ControllerInput/GamepadNavigator:Poll, and we stopped the timer for good. That matches the "controller stops working" reports. Now the sample is skipped (logged once).IsActive), instead of trusting WinUIActivatedevents. Console screen, session menu and the desktop window all pass their handle.CommandforSettingsCard; B closes an open ComboBox.MainWindow: Start toggles Settings, B leaves Settings, Y jumps to the console interface, tour A next / B skip. The ad-hoc "A switches to console" listener inHomeViewis gone; the chip now says "A navigates, Y opens console mode".Test plan
dotnet test: 76 passed; build OKdocs/TESTING.md→ "Navegação por controle" (3 new items: desktop interface, disconnect/reconnect, first-press ring)🤖 Generated with Claude Code