Repository navigation
Remove a stale containerd pid on start - #112
Open
tigerblue77 wants to merge 2 commits into
Open
tigerblue77 wants to merge 2 commits into
tigerblue77 wants to merge 2 commits into
Conversation
/run is not a tmpfs, so an unclean shutdown leaves /run/docker/containerd/containerd.pid behind. If another process has been given that pid by the time dockerd starts, dockerd takes it for a running containerd, never starts one and gives up with "timeout waiting for containerd to start". Nothing can be running yet when init-config-kasm runs, so remove the file there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RmwHZxdRuWgp9chBZTZTMn
1 task done
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RmwHZxdRuWgp9chBZTZTMn
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
init-config-kasmnow removes/var/run/docker/containerd/containerd.pid, next to the staledocker.sockit already removes. It runs before dockerd, when no containerd can be running in the container, so any such file is left over from an unclean shutdown.Benefits of this PR and context:
closes #110
dockerd no longer takes whatever process was given the stale pid for its containerd, so it starts after an unclean shutdown, and
svc-kasmdoes not fail along with it.How Has This Been Tested?
lscr.io/linuxserver/kasm:1.19.0-ls150,docker kill kasm, pid file set to1,docker start kasm:failed to start containerd: timeout waiting for containerd to startin a loop,unable to start service svc-kasm, and Kasm stays down;svc-kasmis up (s6-rc -a list), andfinishruns on the nextdocker stop.Source / References: