Skip to content

Fix for #11 - #12

Closed
TheTumultuousUnicornOfDarkness wants to merge 4 commits into
masterfrom
fix_11
Closed

TheTumultuousUnicornOfDarkness wants to merge 4 commits into
masterfrom
fix_11

Conversation

@TheTumultuousUnicornOfDarkness

Copy link
Copy Markdown
Contributor

Hello,

This is a concrete proposal about #11 (comment).
I did some tests to fix #11, and with these changes, EOG successfully opens when started by Czkawka AppImage.

No more required since ee988ad
Some programs crash due to environment variables override
Fix #11
Full path is mandatory to allow test like '-x' to work when 'command -v' successes
Also, there is no need to 'exit 1' on failure: tests are already done outside this function
linuxdeploy uses uppercase, it makes it more homogeneous
@TheAssassin

Copy link
Copy Markdown
Member

You've found exactly why using $LD_LIBRARY_PATH is not a good idea. Same goes for any environment variable. The moment an external application needs to be run, it'll break.

The solution you proposed is basically a bad hack. Many other tools, e.g., AppImageBuilder, and some KDE thing, rather preload a library with LD_PRELOAD which resets the environment variables. The advantage is that this is way more reliable than exclude-listing a bunch of binaries. Perhaps linuxdeploy should build such a tool, too, that could then be included?

@TheAssassin

Copy link
Copy Markdown
Member

@TheTumultuousUnicornOfDarkness

Copy link
Copy Markdown
Contributor Author

Ok, I understand.
appimage-exec-wrapper seems to be a part of https://github.com/AppImageCrafters/AppRun now.

But Czkawka is written in Rust, and there is no exec() or something like that in this case. I have no knowledge in Rust, so I have no idea what linuxdeploy should intercept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot open images after recent commits

2 participants