Repository navigation
Improve deployment of additional GTK libraries #4
Description
Right now, the deployment of the files is done with cp
linuxdeploy-plugin-gtk/linuxdeploy-plugin-gtk.sh
Lines 127 to 132 in 8a6fa00
and
These changes were introduced by @x0rg in c008df6.
The issue with $LD_LIBRARY_PATH is that it is not side-effect-free with regards to subprocesses created by the processes in the AppImage. We've seen problems created by exactly this constellation with the (now very much deprecated) AppRun.c in AppImageKit. This is why linuxdeploy (and its plugins) usually use the DT_RUNPATH ELF header field instead (see man ld for more information).
linuxdeploy now exports the $LINUXDEPLOY environment variable with its own path, allowing plugins that are run by it to call linuxdeploy and use it to deploy additional libraries. This could and should be used by this plugin to eliminate the dependency on $LD_LIBRARY_PATH.
Note: we should still support standalone runs of this plugins. The easiest way would be to just error out when $LINUXDEPLOY is not set, telling the user to download a suitable linuxdeploy AppImage, set the env var and re-run the plugin.
Activity