Repository navigation
separate the codec driver - #38
Merged
Merged
Conversation
…screen/cpad driver
Open
…uschreen and cpad driver and codec is the audio codec chip
Wolfvak
marked this pull request as ready for review
May 2, 2021 14:10
Member
Author
|
ok, so it's taking longer than expected to deal with CODEC since it requires three pieces: codec support (modified chip from TI, no datasheets or anything), I2S support (simple enough) and the proper PCM engine driver (not that simple), plus all the interconnections between them I think it's acceptable to merge the tsc driver for now, since I won't be able to work on this for a while |
Open
Member
Author
|
alright, pushed another commit that should fix those issues |
nickdesaulniers
approved these changes
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this separates the codec driver that directly accessed the spi bus into a "master" codec device that exposes a regmap, so that two separate drivers ("tsc" and eventually "snd") can access it safely
ideally we would also split off the virtual kbd stuff but I'm not sure drivers can access the internal input state