Repository navigation
fix(terminal): keep a session's browser across Continue in - #980
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A user reported that Continue in loses the session's browser: the card comes back up in the other profile with its browser closed, and the page and its cookies are gone.
ContinueInended the process throughterminal.Close, the same call that closes a card. ItsSetSessionClosedhook is wheremain.goclosed the card's browser (closeSessionBrowser), so the respawn under the same card id found no browser left.The fix splits the two things that hook meant:
endProcessends the process and still tellsSetSessionClosed, so the relay resets its state for the new process as before.CloseByisendProcessplus a newSetCardClosedhook, fired only when the card itself closes. The browser listens to that one.ContinueIncallsendProcessonly.docs/ceilings.mdnow says Continue in keeps the browser.Test plan
TestContinueInKeepsTheCardfailed before the fix (Continue in closed the card [s1]) and passes aftergofmt -l .,go vet ./...,go test ./...