Skip to content

fix(terminal): keep a session's browser across Continue in - #980

Merged
omartelo merged 1 commit into
mainfrom
fix/continue-in-keeps-browser
Oct 29, 2026
Merged

omartelo merged 1 commit into
mainfrom
fix/continue-in-keeps-browser

Conversation

@omartelo

Copy link
Copy Markdown
Collaborator

Summary

A user reported that Continue in loses the session's browser: the card comes back up in the other profile with its browser closed, and the page and its cookies are gone.

ContinueIn ended the process through terminal.Close, the same call that closes a card. Its SetSessionClosed hook is where main.go closed the card's browser (closeSessionBrowser), so the respawn under the same card id found no browser left.

The fix splits the two things that hook meant:

  • endProcess ends the process and still tells SetSessionClosed, so the relay resets its state for the new process as before.
  • CloseBy is endProcess plus a new SetCardClosed hook, fired only when the card itself closes. The browser listens to that one.
  • ContinueIn calls endProcess only.

docs/ceilings.md now says Continue in keeps the browser.

Test plan

  • TestContinueInKeepsTheCard failed before the fix (Continue in closed the card [s1]) and passes after
  • gofmt -l ., go vet ./..., go test ./...

@omartelo
omartelo merged commit 5f1e1cb into main Oct 29, 2026
7 checks passed
@omartelo
omartelo deleted the fix/continue-in-keeps-browser branch October 29, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant