Repository navigation
feat(native): UI polish: status ring, key caps, Settings scope and a one-line palette - #797
Merged
Merged
Conversation
The ring around a session card's icon read heavier than the web window's at the same 1.5 width; 1.25dp reads at the web's weight.
The caps were 6x2dp around 10sp text. They now get 8dp across and 6dp above, with a dp more below for the thicker bottom border, so the text sits centred on the cap's face.
The gear reopened Settings on whatever scope it was last left in, so a visit through a tab's Project settings… made the next theme or hotkey change land in a project scope where those rows are Global only. The gear now always opens on Global; Project settings… still opens a project's own.
Sessions, projects, messages and closed sessions take one line each, the path after the name. A path longer than three parts keeps its last three behind an ellipsis, so a worktree reads as worktrees/<hash>/<name>. A session waiting on the user leads the Sessions group and trails a "waiting" chip in its ring's tone. The order is still taken once per opening, so nothing moves under the cursor. The filter tabs drop their pills: the current one is underlined in the foreground. History keeps the branch and the age on the right, a "checkout gone" chip in place of the branch, and adds a second line only when a search matched the conversation, with the query's words marked. A session that ran in its project's folder shows the project's path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A pass over the native window's UI, one adjustment per commit, each reviewed in a running window.
What changes
sidebar_card.go): the card's ring is drawn 1.25dp instead of 1.5. At the web's 1.5 it read heavier, since Gio blends the antialiased edge in linear light; 1dp was too faint.settings_hotkeys_view.go): 8dp across and 6dp above the text, with a dp more below for the thicker bottom border, so the text sits centred on the cap's face (measured on a shot: 6px above and below). Every cap moves together: Settings › Hotkeys, the palette and the shortcuts overlay.topbar_apply.go): the top bar's gear always opens Settings on Global. It reopened on the scope last left, so after a tab's Project settings… the next theme or hotkey change landed in a project scope where those rows are Global only.showRememberedis gone with it.palette_view.go,palette_logic.go,paths.go):shortPath: a path of more than three parts keeps its last three behind…, so a worktree reads…worktrees/<hash>/<name>;No new catalog keys: the chip reuses
session.filter.phase.waiting.Tests
TestSettingsButtonOpensOnGlobalAfterAProjectScopefailed before the scope change.TestRankSessionsPutsWaitingThenTurnsFirstAndShellsLastreplacesTestRankSessionsPutsTurnsFirstAndShellsLast: the contract changed, the ranking now reads a status rather than a held turn, and two waiting cases are new.TestOnlyAWaitingSessionTrailsTheWaitingChip,TestQuerySegmentsMarksEveryToken,TestShortPathKeepsTheLastThreeParts(Linux and Windows paths).The native gate (gofmt, vet,
go test ./...under Xvfb with no render test skipped) is green. Backend and frontend are untouched.Not covered