Skip to content

Create Guides section - #174

Merged
salmad3 merged 4 commits into
revampfrom
guides
Sep 8, 2022
Merged

salmad3 merged 4 commits into
revampfrom
guides

Conversation

@salmad3

@salmad3 salmad3 commented Aug 31, 2022 •

Copy link
Copy Markdown
Contributor

Context

  • Creates dedicated section for technical how-tos, configuration, examples under a "Guides" category
  • We will eventually pull in examples for each implementation, putting one or two 101-type of examples in the sub-section, then linking to examples source available for each implementation

Part of #29

Latest preview

Please view the latest Fleek preview here.

@netlify

netlify Bot commented Aug 31, 2022 •

Copy link
Copy Markdown

✅ Deploy Preview for libp2p-docs-mirror ready!

Name Link
🔨 Latest commit f8704e2
🔍 Latest deploy log https://app.netlify.com/sites/libp2p-docs-mirror/deploys/6318643936f48e000bd717ba
😎 Deploy Preview https://deploy-preview-174--libp2p-docs-mirror.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@salmad3
salmad3 marked this pull request as draft August 31, 2022 05:06
@salmad3 salmad3 changed the title Create Guides section Create Guides section and link examples Aug 31, 2022
@salmad3 salmad3 added ready for review PR is ready for review and removed in progress labels Sep 1, 2022
@salmad3
salmad3 marked this pull request as ready for review September 1, 2022 10:02
@salmad3 salmad3 changed the title Create Guides section and link examples Create Guides section Sep 1, 2022

@marten-seemann marten-seemann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Not sure if it belongs to this PR, but should Examples and Tutorials be at the same level?

@salmad3

salmad3 commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

Not sure if it belongs to this PR, but should Examples and Tutorials be at the same level?

Do you mean that one should be a subsection of the other?

@marten-seemann

Copy link
Copy Markdown
Contributor

Not sure if it belongs to this PR, but should Examples and Tutorials be at the same level?

Do you mean that one should be a subsection of the other?

The other way around actually. I was suggesting that Example and Tutorials should both be nested directly under Guides.

@salmad3

salmad3 commented Sep 7, 2022

Copy link
Copy Markdown
Contributor Author

Not sure if it belongs to this PR, but should Examples and Tutorials be at the same level?

Do you mean that one should be a subsection of the other?

The other way around actually. I was suggesting that Example and Tutorials should both be nested directly under Guides.

Oh they are @marten-seemann. "Tutorials" looks like a sub-section as the toggle is pushing the positioning of the section. They would be positioned equally once "Examples" has example pages.

Added a placeholder file to fix:
image

@salmad3
salmad3 changed the base branch from master to revamp September 8, 2022 03:27
@salmad3

salmad3 commented Sep 8, 2022 •

Copy link
Copy Markdown
Contributor Author

Will add this to the overall design update to include the Guides section and request a review there.

@salmad3 salmad3 removed the ready for review PR is ready for review label Sep 8, 2022
@salmad3
salmad3 merged commit 6f46894 into revamp Sep 8, 2022
@salmad3
salmad3 deleted the guides branch January 3, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants