You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
use pythonic options instead of _ad hoc_ name variations for igl function overloads #172
The first returning all boundary loops and the second returning the longest. In the current python bindings these manifest as igl.all_boundary_loop and igl.boundary_loop.
To avoid confusion (see, e.g., #67, #124), the python binding names should match as closely as possible to the underlying C++ function.
The pythonic solution would be to use kwarg optional arguments like
igl.boundary_loop(F) # defaults to return_all=Falseigl.boundary_loop(F,return_all=True)
I'm not sure yet how to set these up with pybind11 but it seems possible.
Activity