Repository navigation
hiredis.c should return git_error_code, not git_error_t? #8
Description
Should hiredis.c return a git_error_code type and not git_error_t? Libgit2 checks for if (error < 0) which does not catch git_error_t types.
This manifested in a nullptr instead of an error when trying git_blob_lookup_prefix against hiredis backend.
See https://github.com/libgit2/libgit2-backends/blob/master/redis/hiredis.c#L158 and https://github.com/libgit2/libgit2/blob/master/src/object.c#L190.
Activity
ideal commentedon Oct 27, 2015
You are right.
return code for error should be below than 0. git_error_t is for giterr_set().