Conversation
kev009
left a comment
kev009
left a comment
There was a problem hiding this comment.
The remaining identifiers match their existing license headers, including the historical CC-PDDC dedication. git diff --check is clean, and the patch changes comments only.
This does not appear to be intended as a repository-wide SPDX pass—tests and several CMake files remain untagged. That is fine, but it would help to clarify the intended scope in the PR description.
| @@ -1,4 +1,6 @@ | |||
| /* | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
This file already has the identical SPDX-License-Identifier: Apache-2.0 below at line 7. Please remove this addition, or drop commit 124ac82c entirely.
There was a problem hiding this comment.
I've update this one. Slipped through my eyes.
| @@ -1,5 +1,7 @@ | |||
| /* $OpenBSD: tree.h,v 1.7 2002/10/17 21:51:54 art Exp $ */ | |||
| /* | |||
| * SPDX-License-Identifier: BSD-2-Clause | |||
There was a problem hiding this comment.
Please add the same BSD-2-Clause identifier to WIN32-Code/tree.h. It has the same license header and is also shipped by the build, so leaving that copy untagged appears accidental.
Add SPDX-License-Identifier to files with BSD-3-Clause AND CC-PDDC
I can tag CMakefiles. Am I wrong if assume they are |
Yes the 3-clause covers all the project files by default |
Add SPDX-License-Identifier to files with BSD-3-Clause
Add SPDX-License-Identifier to files with BSD-2-Clause
Add SPDX-License-Identifier to files with MIT
Add SPDX-License-Identifier to files with curl
Add SPDX-License-Identifier to files with ISC
Add SPDX-License-Identifier to files with LicenseRef-PublicDomain
463d477 to
e4f42b2
Compare
This one I didn't quit get. Should they be just |
I've added them also with a update. For me it's ok to squash everything into one commit if it's more convenient. |
2 participants
Add SPDX-License-Identifiers for files. Different licenses are in separated commits.