Skip to content

Change "Site_Type" and "Index_Region" to "Index_Class" #83

Open

Description

@leppott

Is your feature request related to a problem? Please describe.
Have used Site_Type and Index_Region in multiple places between BioMonTools and BCGcalc packages.

Change to "Index_Class"

Describe the solution you'd like
Will need to deprecate the input parameter in files.

Describe alternatives you've considered
Need consistency between packages.

Additional context
Will have to change:

  • functions (input parameters)
  • examples
  • example files.
  • vignettes
  • other?

Activity

  1. leppott commented on Nov 15, 2022

    @leppott
    OwnerAuthor
    • ext\DataBenthos.xlsx
    • ext\MetricFlags.xlsx
    • ext\MetricScoring.xlsx
    • qc_checks.R
    • metric_values.R
    • metric_values_excel.R
    • metric_scores.R
    • data.R
    • data-raw\data_benthos_MBSS
    • data-raw\data_benthos_PacNW
    • data-raw\data_diatom_mmi_dev
    • data-raw\data_diatom_mmi_qc
    • data-raw\data_fish_MBSS
    • data-raw\metval_SCMB_IBI
    • data-raw\data_mmi_dev
    • vignette
    • Shiny,
  2. leppott commented on Nov 16, 2022

    @leppott
    OwnerAuthor

    Calculation slower. Will need to fix.

    Modified mutate, if_numeric, replace_na statement to use a data frame and not a tibble. The grouping was making it take minutes instead of < 2 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions