Skip to content

[Bug][chore] possible typo of lokr tensor name variable #1643

Description

@masamaru-san

Git commit

master: 19bdfe2

Original Commit 1be2491 "feat: partial LyCORIS support (tucker decomposition for LoCon + LoHa + LoKr)" is OK.
Introduced from Commit 9f56833 "feat: optimize LoKr at runtime".

Operating System & Version

N/A

GGML backends

CPU

Command-line arguments used

N/A

Steps to reproduce

Line 615 must be lokr_w2_a_name, but I can't verify it since I don't have the LoKR model.

if (lokr_w2)
applied_lora_tensors.insert(lokr_w2_name);
if (lokr_w2_a)
applied_lora_tensors.insert(lokr_w2_name);
if (lokr_w2_b)
applied_lora_tensors.insert(lokr_w2_b_name);

What you expected to happen

--

What actually happened

--

Logs / error messages / stack trace

No response

Additional context / environment details

Why was this issue posted?:

If this really was a typo, the repetitive code could be simplified.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions