Conversation
`get_effective_disk_space()` was only read for display, so uploads and publishes were still checked against the admin-granted `disk_space` alone and a subscriber hit a 412 on space they had paid for. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xxy9NqytrugNq59yquMRBA
Count subscription storage towards the upload quota
rtibbles
marked this pull request as ready for review
September 21, 2026 23:53
radinamatic
approved these changes
Sep 21, 2026
radinamatic
left a comment
radinamatic
left a comment
Member
There was a problem hiding this comment.
I have 587MB used storage confirming the fix! 💯 
🚀
Member
Author
|
Emergency release, merging with only one approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users with a storage subscription were refused uploads and publishes once they passed their admin-granted disk space, even though the paid-for space was still free. Single-PR patch release that checks free space against the effective disk space — admin-granted plus subscription — instead.
References
#6157. Subscription storage added in #5810.
Reviewer guidance
disk_spaceallowance, then upload a file that still fits within the subscribed total — the upload and a subsequent publish both succeed instead of returning 412Open risk:
upload_urlrequest makes an extra query for the subscription row — one per file on a bulk upload.AI usage
Used Claude Code to draft this release PR from the merged hotfix and its commit history. I cross-checked the QA focus against the diff.