Repository navigation
Updated VBtn to KButton for New Collection - #5275
Conversation
|
Thanks @yeshwanth235, I will review next week. |
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
Thank you @yeshwanth235, all looks good. Just small cleanup and we can merge.
Note that we may need to wait few days before merging because of pre-release preparations.
| > | ||
| {{ $tr('finish') }} | ||
| </VBtn> | ||
| <div> |
There was a problem hiding this comment.
It doesn't seem this <div> serves any function, and it wasn't there before either. Let's cleaned it up, and then we can merge. Thanks!
There was a problem hiding this comment.
Without div the footer looks like this.
With div
Hence added the div
There was a problem hiding this comment.
Removed the div and added a class to kButton to adjust the height.
There was a problem hiding this comment.
Ah that's unusual. Do you know why the button was spreading that way?
There was a problem hiding this comment.
The CSS for KButton includes a min-height property. Because the footer has a greater height, the button’s height has increased to match it.
The button’s min-height ensures a minimum size, but parent or surrounding elements can cause it to appear taller.
There was a problem hiding this comment.
Ah okay, thank you. There's probably some style in the bottom bar, perhaps flex, that affects its height.
In that case setting the height explicitly will be better than applying that div - it makes clearer to others what's going on.
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
Everything as expected and I manually confirmed that buttons work just fine. Thank you @yeshwanth235 :)
2 participants
Summary
Updated VBtn to KButton for New Collection
References
5243
Reviewer guidance
Test buttons in Channels > Collections > New collection.
Should working as expected.