Skip to content

[Remove Vuetify from Studio] Sign-in page #5930

Description

@MisRob

Overview

Remove Vuetify from the Sign-in page.

Complexity: Low

Context

Sign-in page:

Image Image

The Change

Remove Vuetify dependencies in this location by:

  • Replace VCard with StudioRaisedBox
  • Replace Banner with StudioBanner
  • Remove VLayout and VDivider in favor of custom styles
  • Replace VForm with <form> and use generateFormMixin for validation
  • Replace EmailField / PasswordField by StudioEmailField / StudioPasswordField

Ensure that all interactions are functional as before. Do not modify Banner, EmailField and PasswordField. Do not refactor any other areas of the codebase.

How to Get There

  • Navigate to /accounts

Guidance

Out of Scope

  • Do not modify Banner, EmailField and PasswordField
  • Do not refactor any other areas of the codebase

Expected UI/UX changes

  • Error banner text will be black and there will be an error icon (introduced in Improve alert banner #5687 & meant to be applied to all error banners consistently)
  • Minor visual differences naturally stemming from the use of KDS

Acceptance Criteria

These are general acceptance criteria for the project. For each sub-issue, consider which are relevant.

General

  • The specification above is followed.
  • Except for "Expected UI/UX changes," there are no functional or visual differences in user experience.
  • There are no regressions in the printing preview
  • There are no ::v-deep or /deep/ selectors.
  • All user interactions are manually tested with no regressions.
  • Pull request includes screenshots.

a11y and i18n

See the project's "Guidance" for useful references.

  • Implementation meets a11y standards
  • All components are LTR and RTL compliant (preview with pnpm run devserver since :hot doesn't render RTL properly)
  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text)
  • Mobile experience is reasonable

Unit tests

  • If there is a unit test suite already, it is meaningfully updated (even if tests don't fail)
  • If there is no unit test suite, a new one is created. Do not use obsolete @vue/test-utils approach. Instead, use @testing-library/vue (Vue Testing Library).

References

Sub-issue of #5060

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions