Skip to content

[Remove Vuetify from Studio] Permanently delete resource confirmation dialog聽#5443

Description

@MisRob

馃檪 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you鈥檙e requesting an issue, please:

  • Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don鈥檛 follow the guidelines won鈥檛 be answered.
  • Confirm that you鈥檝e read the guidelines in your comment.

Sub-issue of #5060.

Complexity: Low

Summary

Migrate the Permanently delete confirmation dialog in Edit channel > Trash from Vuetify to Kolibri Design System.

Image

MessageDialog built with several Vuetify components is currently used to show it. To remove this Vuetify dependency, replace the usage of MessageDialog in these specific locations with KModal. Ensure that the dialog work exactly as before. Do not refactor any other areas.

How to get there

  • Login as a@a.com with password a
  • Go to Channels > Published Channel
  • Select Sample Video
  • Click Remove
  • Open trash from the ... dropdown at the top of the page
  • Select Sample Video
  • Click Delete

Guidance

Out of Scope

  • Do not refactor any other areas of the codebase

Expected UI/UX changes

  • Minor visual differences naturally stemming from the use of KDS

Acceptance criteria

These are general acceptance criteria for the project. For each sub-issue, consider which are relevant.

General

  • The specification above is followed.
  • Except for "Expected UI/UX changes," there are no functional or visual differences in user experience.
  • There are no ::v-deep or /deep/ selectors.
  • All user interactions are manually tested with no regressions.
  • Pull request includes screenshots.

a11y and i18n

See the project's "Guidance" for useful references.

  • Implementation meets a11y standards
  • All components are LTR and RTL compliant (preview with pnpm run devserver since :hot doesn't render RTL properly)
  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text)
  • Mobile experience is reasonable

Unit tests

  • If there is a unit test suite already, it is meaningfully updated (even if tests don't fail)
  • If there is no unit test suite, a new one is created. Do not use obsolete @vue/test-utils approach. Instead, use @testing-library/vue (Vue Testing Library).

Activity

  1. z-ABYa commented on Oct 9, 2025

    @z-ABYa
    Contributor

    Hey @MisRob i'd like to work on this issue.

  2. Abhishek-Punhani commented on Oct 9, 2025

    @Abhishek-Punhani
    Member

    Hi @MisRob, can I work on this?

  3. MisRob commented on Oct 9, 2025

    @MisRob
    MemberAuthor

    Hi both. I will assign @z-ABYa here, @Abhishek-Punhani I believe there should be few another free issues where no one has yet volunteered for. Thanks a lot!

  4. z-ABYa commented on Oct 14, 2025

    @z-ABYa
    Contributor

    Hi @MisRob. i've made the required changes to the Permanently delete confirmation dialog in Edit channel > Trash. But i couldn't seem to start the dev server, until i changed the /deep/ tags to ::v-deep and some changes in the path of redis and postgres in package.json (as i'm using M1 mac). So my question is should i do a PR with all these changes or just what i was assigned. Also, going forward how should i run the dev server?

    p.s: It currently has a unit test suite but uses obsolete @vue/test-utils, so does that also fall under the scope of the assignment? Thank you!

  5. MisRob commented on Oct 15, 2025

    @MisRob
    MemberAuthor

    Hi @z-ABYa,

    which of the guides you followed when setting up the development server?

    As for the PR for this task, thanks for asking how to proceed. Let's not commit the extra changes you did to be able to run the server. VTL requirement for unit testing only applies to completely new test suites. In existing @vue/test-utils suites, you can stay with the obsolete approach and just update tests directly related to your task.

  6. z-ABYa commented on Oct 15, 2025

    @z-ABYa
    Contributor

    Hi @MisRob, I started with following docker guide, as it is supposed to be better, but one of the error was docker couldn't find the bitnami/minio image

    manifest for bitnami/minio:2024.5.28 not found

    (which i later found out to have been deprecated). So i eventually switched to the local host guide, which finally ran after said changes. As for the unit test suite i'll update the existing file related to the task and commit it after discarding the unnecessary changes.

    Thanks for being patient!

  7. MisRob commented on Oct 15, 2025

    @MisRob
    MemberAuthor

    @z-ABYa Glad you've figured it out and all works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions