Skip to content

[Remove Vuetify from Studio] Add / remove admin privileges dialogs #5441

Description

@MisRob

🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:

  • Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don’t follow the guidelines won’t be answered.
  • Confirm that you’ve read the guidelines in your comment.

Sub-issue of #5060.

Complexity: Low

Summary

Remove Vuetify from Add / remove admin privileges dialogs in Administration > Users, including validation:

VForm, VTextField, Vuetify-based validation, VBtn, and MessageDialog built with several Vuetify components, are currently used.

Remove these dependencies on Vuetify in this specific location by:

  • Replace MessageDialog by KModal
  • Replace VForm by <form>
  • Replace VTextField by KTextbox
  • Use generateFormMixin for validation

Ensure that the dialog work exactly as before. Do not refactor any other areas.

How to get there

  • Login as a@a.com with password a
  • Go to Administration > Users
  • Click Actions dropdown in the last column of the table
  • Click Add / remove admin privileges

Guidance

Out of Scope

  • Do not refactor any other areas of the codebase

Expected UI/UX changes

  • Minor visual differences naturally stemming from the use of KDS

Acceptance criteria

General

  • The specification above is followed.
  • Except for "Expected UI/UX changes," there are no functional or visual differences in user experience.
  • There are no ::v-deep or /deep/ selectors.
  • All user interactions are manually tested with no regressions.
  • Pull request includes screenshots.

a11y and i18n

See the project's "Guidance" for useful references.

  • Implementation meets a11y standards
  • All components are LTR and RTL compliant (preview with pnpm run devserver since :hot doesn't render RTL properly)
  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text)
  • Mobile experience is reasonable

Unit tests

  • If there is a unit test suite already, it is meaningfully updated (even if tests don't fail)
  • If there is no unit test suite, a new one is created. Do not use obsolete @vue/test-utils approach. Instead, use @testing-library/vue (Vue Testing Library).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions