Skip to content

[Remove Vuetify from Studio] Upload in progress and Save failed dialogs聽#5422

Description

@MisRob

馃檪 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you鈥檙e requesting an issue, please:

  • Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don鈥檛 follow the guidelines won鈥檛 be answered.
  • Confirm that you鈥檝e read the guidelines in your comment.

Sub-issue of #5060.

Complexity: Low

Summary

Migrate the following two dialogs in Edit resource from Vuetify to Kolibri Design System.

MessageDialog built with several Vuetify components is currently used to show them. To remove this Vuetify dependency, replace the usage of MessageDialog in these specific locations with KModal. Ensure that dialogs work exactly as before. Do not refactor any other areas.

How to get there

  • Login as a@a.com with password a
  • Go to Channels > Published Channel
  • Select Sample video
  • In code, temporarily change promptUploading and promptFailed to true

Guidance

Out of Scope

  • Do not refactor any other areas of the codebase

Expected UI/UX changes

  • Minor visual differences naturally stemming from the use of KDS

Acceptance criteria

General

  • The specification above is followed.
  • Except for "Expected UI/UX changes," there are no functional or visual differences in user experience.
  • All user interactions are manually tested with no regressions.
  • Pull request includes screenshots.

a11y and i18n

See the project's "Guidance" for useful references.

  • Implementation meets a11y standards
  • All components are LTR and RTL compliant (preview with pnpm run devserver since :hot doesn't render RTL properly)
  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text)
  • Mobile experience is reasonable

Unit tests

  • If there is a unit test suite already, it is meaningfully updated (even if tests don't fail)
  • If there is no unit test suite, a new one is created. Do not use obsolete @vue/test-utils approach. Instead, use @testing-library/vue (Vue Testing Library).

Activity

  1. ANAS727189 commented on Oct 2, 2025

    @ANAS727189
    Contributor

    @MisRob I will solve this issue and create a pr. Please assign it to me.

  2. MisRob commented on Oct 3, 2025

    @MisRob
    MemberAuthor

    Hi @ANAS727189 - thank you. I will assign you. Also please do check the contributing guidelines, where besides other guidance, you will see on how many issues to request assignment.

  3. added a commit that references this issue on Oct 3, 2025
    ef892cf
  4. ANAS727189 commented on Oct 3, 2025

    @ANAS727189
    Contributor

    @MisRob I鈥檝e created a PR for this issue. Could you please review it and let me know if any changes are needed?

  5. MisRob commented on Oct 6, 2025

    @MisRob
    MemberAuthor

    Thank you @ANAS727189, we will have a look.

  6. added a commit that references this issue on Oct 20, 2025
    05b7e71
  7. added a commit that references this issue on Nov 20, 2025
    716a47e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions