Repository navigation
[Remove Vuetify from Studio] Buttons in disk space popup in Administration - Users聽#5354
Description
Activity
hi @MisRob
i would like to work on this issue, so can you please assign this to meHello @MisRob,
I hope this message finds you well. My name is Prashant and I鈥檓 new to open-source contribution. I鈥檓 very excited about Learning Equality鈥檚 mission and would love to contribute.
I鈥檝e carefully read the contributing guidelines and set up the development environment locally.
i would too like to work on this issue,if it is not assigned yet.Hi @akramcodez and @Prashant-thakur77, welcome!
For this issue, I will assign @akramcodez who requested at first.
@Prashant-thakur77 Thank you for confirming you saw the guidelines and I'm glad you were able to set up your dev environment. I am adding new issues to the project on at least weekly basis - please keep an eye on 'help wanted' list and we will be glad to assign you one of the upcoming ones.
Reacted by Prashant-thakur77sure
Hi @akramcodez 馃憢
I noticed you're working on this issue. If you need any help or want to collaborate, I'm happy to assist!
@akramcodez are you working on this issue?
Hi @MisRob I want to work on this issue could you please assign to me ?
8 remaining items
Hi @MisRob, I'm interested in working on this issue.
I've genuinely enjoyed contributing to this project and would love to continue working on more issues. Each task has been a valuable learning experience, I'm also available for medium-complexity issues and would appreciate being considered for future tasks :) Thanks..
Reacted by Alex VelezHey @Prashant-thakur77! Thanks for all your contributions and your interest in working on this issue. I'll assign this to you! And thanks! We'll consider you when medium-complexity issues are opened <3
Reacted by Prashant-thakur77Hi @MisRob, I have a quick question about KButtonGroup.
I've noticed that KButtonGroup doesn't have white-space: nowrap styling, which works fine on desktop but causes buttons to wrap on smaller screens.
I'm curious if this is intentional, or would it be helpful to add this style to prevent wrapping?
Thanks for your insight!
The problem:
Used Kbutton group hereThanks for reaching out!
Yes, it's true we quite often run into scenarios where buttons shouldn't wrap. I would be hesitant to apply
white-space: nowrapeverywhere by default though. I think it could lead to unexpected overflows in some cases - and those are worse than unexpected wrap from the user point of view. Overflow can result in elements not being reachable at all.However, I think it would definitely make sense to have it easily configurable from outside, and even documented as an example in KDS documentation. If you apply
<KIconButton :style="{'white-space': 'nowrap'}" />, will it take effect? Depending on the context, it may also be needed to ensure that the container doesn't limit available space.Reacted by Prashant-thakur77@Prashant-thakur77 I've just edited my original reply with the suggestion to try out
<KIconButton :style="{'white-space': 'nowrap'}" />- it was formatted badly and didn't show up.If that works, we shouldn't need a new prop. But if it's not possible to easily override from outside, we can consider.
Reacted by Prashant-thakur77Reacted by Prashant-thakur77Sorry
<KButtonGroup>I meant :)Reacted by Prashant-thakur77@Prashant-thakur77 as for a Medium issue you mentioned above, since you have some nice experience with the project, I am happy to assign you the next one I prepare - likely tomorrow or next week.
Reacted by Prashant-thakur77Sure @MisRob would love to work on it ;)
JUST raised the pr for this issue too;).Do tell if any changes are required.
Thanks for contributing .We will assign a reviewer for your PR soon!
Reacted by Prashant-thakur77
馃檪 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you鈥檙e requesting an issue, please:
Sub-issue of #5060.
Complexity: Low
Summary
Migrate the following buttons in Administration > Users > Edit disk space from Vuetify to Kolibri Design System.
VBtnis currently used to show them. To remove this Vuetify dependency , replace the usage ofVBtnin this specific location with the most suitable KDS button or link components. Ensure that all buttons work exactly as before.How to get there
a@a.comwith passwordaGuidance
Out of Scope
Expected UI/UX changes
Acceptance criteria
General
a11y and i18n
See the project's "Guidance" for useful references.
pnpm run devserversince:hotdoesn't render RTL properly)notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text)Unit tests
@vue/test-utilsapproach. Instead, use@testing-library/vue(Vue Testing Library).