Skip to content

[Remove Vuetify from Studio] 'Unsaved changes' modal in Channels - New collection聽#5299

Description

@MisRob

馃檪 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you鈥檙e requesting an issue, please:

  • Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don鈥檛 follow the guidelines won鈥檛 be answered.
  • Confirm that you鈥檝e read the guidelines in your comment.

Sub-issue of #5060.

Complexity: Low

Summary

Remove Vuetify from Unsaved changes modal in Channels > Collections > New collection:

MessageDialog.vue built with several Vuetify components is currently used for this modal:

<MessageDialog
v-model="showUnsavedDialog"
:header="$tr('unsavedChangesHeader')"
:text="$tr('unsavedChangesText')"
data-test="dialog-unsaved"
:data-test-visible="showUnsavedDialog"
>
<template #buttons>
<VSpacer />
<VBtn
flat
@click="confirmCancel"
>
{{ $tr('closeButton') }}
</VBtn>
<VBtn
color="primary"
@click="save"
>
{{ $tr('saveButton') }}
</VBtn>
</template>
</MessageDialog>

Remove dependencies on Vuetify by using KModal instead of MessageDialog.

Do not modify MessageDialog.vue or how it's used at another places.

How to get there

  • Login as user@a.com with password a
  • Go to Channels > Collections
  • Click New collection button
  • Add some text to Collection name input
  • Click the close button in the top bar

Guidance

Out of Scope

  • Do not modify MessageDialog.vue
  • Do not refactor any other areas of the codebase

Expected UI/UX changes

  • Minor visual differences naturally stemming from the use of KDS

Acceptance criteria

General

  • The specification above is followed.
  • Except for "Expected UI/UX changes," there are no functional or visual differences in user experience.
  • All user interactions are manually tested with no regressions.
  • Pull request includes screenshots.

a11y and i18n

See the project's "Guidance" for useful references.

  • Implementation meets a11y standards
  • All components are LTR and RTL compliant (preview with pnpm run devserver since :hot doesn't render RTL properly)
  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text)
  • Mobile experience is reasonable

Unit tests

  • If there is a unit test suite already, it is meaningfully updated (even if tests don't fail)
  • If there is no unit test suite, a new one is created. Do not use obsolete @vue/test-utils approach. Instead, use @testing-library/vue (Vue Testing Library).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions