Repository navigation
[Remove Vuetify from Studio] Collection channels loader in Channels - New collection #5244
Description
Activity
- addedgood first issueSelf-contained, straightforward, low-complexitySelf-contained, straightforward, low-complexityhelp wantedOpen source contributors welcomeOpen source contributors welcome
on Aug 4, 2025 Hi @MisRob I would like to work on this issue
@vijay-x-Raj I'll assign you. Thank you
Hi @vtushar06 I've assigned you to this issue: #5296 we can give @vijay-x-Raj a little more time here before we unassign - we like to give people a month to get to grips with issues.
Okay no problem @rtibbles.
We haven't heard back from @vijay-x-Raj for over a month - unassigning.
Hi @MisRob, I want to give this a try, if possible I would love to contribute to this.
10 remaining items
I have submitted a pull request addressing this issue:
The fix introduces a new
<StudioLargeLoader>component built on top of<KCircularLoader>, and replaces old Vuetify-based loaders.- Updated
ChannelSetModal.vueto use<StudioLargeLoader>. - Updated
Storage/index.vueto use<StudioLargeLoader>.
The loaders have been tested and are functioning correctly with a modern, consistent design.
- Updated
Thank you @nishatalam24! We will assign the PR to someone on our team for review. Please anticipate that you may not get review comments until next week.
Reacted by NISHAT ALAM ANSARIWe haven't heard from @nishatalam24 for a long time already. Agreed with @akolson that we will unassign and let someone else to complete this task. For a new assignee - you will need to work in a new branch, but please refer to #5388 and follow existing @akolson's review carefully.
Hi @MisRob I would like to work on this issue:)
Assigned, thank you @Prashant-thakur77
Reacted by Prashant-thakur77Same as with the other issue @Prashant-thakur77, we'd very much appreciated if you could have a look at @akolson's review on the attempt from another contributor. Linked above.
Reacted by Prashant-thakur77Hi @MisRob we have to create a test file for StudioLargeLoader?
I don't think so @Prashant-thakur77 - it's just a wrapper around
KCircularLoader(which we don't want to test from Studio itself - it's KDS responsibility). Thanks for asking - appreciated.Reacted by Prashant-thakur77Just Raised the pr:) for this issue.
Hi @Prashant-thakur77, Thanks for contributing .We will assign a reviewer for your PR soon!
Reacted by Prashant-thakur77
🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:
Sub-issue of #5060.
Complexity: Low
Summary
Remove Vuetify from collection channels loader in Channels > Collections > New collection:
shared/views/LoadingText, which is built with several Vuetify components, is currently used to display the loader.To remove this Vuetify dependency from
ChannelSetModal:shared/views/StudioLargeLoader.vuethat doesn't use Vuetify components but instead:KCircularLoaderLoadingTextLoadingText'sabsolutepropLoadingTextin this specific location withStudioLargeLoaderdivandKCircularLoaderin Settings > Storage overview byStudioLargeLoader:studio/contentcuration/contentcuration/frontend/settings/pages/Storage/index.vue
Lines 50 to 55 in 294f4b8
Do not modify
LoadingText.How to get there
loadingChannelsto truthyuser@a.comwith passwordaGuidance
Out of Scope
LoadingTextExpected UI/UX changes
Acceptance criteria
General
a11y and i18n
See the project's "Guidance" for useful references.
pnpm run devserversince:hotdoesn't render RTL properly)notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text)Unit tests
@vue/test-utilsapproach. Instead, use@testing-library/vue(Vue Testing Library).