Repository navigation
Missing Checkbox Labels #4525
Description
Observed behavior
Checkbox Labels for the Languages, Licenses and Formats dropdown menus located on the Content Library Page are missing.
Expected behavior
The following checkbox labels should have been visible.
User-facing consequences
The absence of the checkbox label may cause confusion and potentially lead to unintended selections.
Steps to reproduce the issue
- Navigate to http://localhost:8080/en/channels/#/public
- Click the dropdown menu next to Formats/Languages/Licenses
Usage Details
- OS: Ubuntu
- Browser: Firefox
Activity
shivansh-bhatnagar18 commentedon Apr 20, 2024
@BabyElias @MisRob kindly review the PR #4527 where I have fixed the checkbox labels issue
shivansh-bhatnagar18 commentedon Apr 27, 2024
@bjester Could you please assign me this issue?
bjester commentedon Apr 29, 2024
@shivansh-bhatnagar18 I've assigned you! Thank you for reaching out. Please take a look at the linked items in this comment for context on this regression. The problem that I saw with your PR is that it removed text truncation from the languages, which is something you may not encounter in development because of how the filter values are constrained to what results are available. Additionally, the
notranslateclass is also important. Therefore, I'd suggest you follow the changes that caused the regression and identify the fix to counteract them.If you encounter questions regarding why something was implemented, I do recommend looking at the
git blameand following those commits here on Github to the PR, which should illuminate the reasons. If you're unsure, please ask!shivansh-bhatnagar18 commentedon May 2, 2024
@bjester Could you please help me out with what does this "label" slot mentioned in the template do here because removing it seems to solve the issue.
bjester commentedon May 2, 2024
@shivansh-bhatnagar18 So for some background, it's our intent to replace all Vuetify components with components from our Kolibri Design System library. We recently accomplished this for checkboxes. Looking at the linked documentation for
KCheckbox, there is no#labelslot but there is a default slot.