Skip to content

KCheckbox/KRadioButton not showing outline when focused in keyboard navigation #4428

Closed

Description

@AlexVelezLl

Observed behavior

Currently, if we navigate with the keyboard, and focus on a KCheckbox or a KRadioButton, they do not show any outline, and it makes it impossible for users to know if it is really focused.

It seems to be an issue with the Kolibri Design System's globalThemeState.inputModality not recognizing that we are navigating with the keyboard, so it is returning a none outline to the $coreOutline (code).

Expected behavior

KCheckboxes and KRadioButtons should show an outline similar to this:
image

Additional information

An example of where we can find some KRadioButtons where we can test this problem is in the Studio: Settings section > Storage > Open form.

It is probably a missconfiguration of KDS in Studio, and it doesnt happen in Kolibri, so we can check Kolibri's Theme configuration as reference.

Activity

  1. Abhishekzod007 commented on Feb 8, 2024

    @Abhishekzod007
    Contributor

    Hello @AlexVelezLl , I am a new contributor to this repository and I want to contribute in this so that I can solve as many issues related with this. Could you please assign this issue to me?

  2. AlexVelezLl commented on Feb 8, 2024

    @AlexVelezLl
    MemberAuthor

    Hi @Abhishekzod007! Thank you for your interest of contributing to Learning Equality! Actually, I wouldnt recommend this as a first issue, since it has some dependencies with other of our products as KDS, and compare theme settings with Kolibri. If you feel confortable working with these products too let me know.

  3. Abhishekzod007 commented on Feb 8, 2024

    @Abhishekzod007
    Contributor

    Actually I was trying to set up the studio on my local environment but encountered some issues even after trying many times, I asked about this problem on discussions section but no one replied and after sometime my request was deleted itself(don't know how?). Could you please help me to solve out that so that I will start contributing by my ownside.

  4. AlexVelezLl commented on Feb 8, 2024

    @AlexVelezLl
    MemberAuthor

    @Abhishekzod007 I see that you opened this discussion some hours ago. One of our colleagues left you a suggestion to solve the problem. If that didn't work, please feel free to reopen the discussion with any update 👐

  5. Abhishekzod007 commented on Feb 9, 2024

    @Abhishekzod007
    Contributor

    Ok , Thanks I'll let you know.

  6. nikkuAg commented on Feb 10, 2024

    @nikkuAg
    Contributor

    Hey, is this issue still open? I would like to work on this.

  7. AlexVelezLl commented on Feb 11, 2024

    @AlexVelezLl
    MemberAuthor

    Hi @nikkuAg! I see you are facing some problems running studio, I just replied in #4171. So we can finish setting up the project first and then raise a PR for the issue you already have assigned before continuing with other issues.

  8. self-assigned this
    on Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions