Repository navigation
Incorrect folders/resources count when moving from the clipboard聽#3744
Description
Observed behavior
While moving a folder with resources from the clipboard to the curator's channel topic tree, the title with summary always stays at 0 folders, 0 resources 馃憤馃徑
Expected behavior
Title should report the correct number of folders and resources, same as stated at origin (clipboard, 1 folder, 20 resources in the recording above)
User-facing consequences
Uncertainty and confusion about what is being moved from the clipboard.
Errors and logs
Nothing in the console or user-facing.
Steps to reproduce the issue
- Select folder/resource in the clipboard
- Click on the
Movebutton - Observe the title in the next window
Usage Details
- OS: Ubuntu 20.04
- Browser: both Firefox and Chromium
Activity
radinamatic commentedon Oct 18, 2022
cc @bjester
bjester commentedon Oct 18, 2022
@radinamatic This seems to be an existing issue, so I'm going to downgrade this from P0 to remove this as a release blocker.
radinamatic commentedon Oct 18, 2022
My bad for not remembering that, I thought I searched enough...
Agreed it's not a regression then, would the fix be time demanding?
[-]Hotfixes - Incorrect folders/resources count when moving fromthe clipboard[/-][+]Incorrect folders/resources count when moving fromthe clipboard[/+][-]Incorrect folders/resources count when moving fromthe clipboard[/-][+]Incorrect folders/resources count when moving from the clipboard[/+]bjester commentedon Jun 20, 2023
This is still extant. Will take a look
nucleogenesis commentedon Jul 30, 2024
@LianaHarris360 (cc @marcellamaki @rtibbles)
I'm going to leave some notes behind here re: the clipboard issue.
My branch: https://github.com/nucleogenesis/studio/tree/fix--clipbaord-checkboxes-and-numbers
I fixed a problem w/ checkboxes here. Without this you'll not be able to select anything in the clipboard
I've done a bunch of digging and have a solid lead on what the issue is but I don't know how to fix it correctly. I'd ask Blaine or Richard if I were coming back to this tomorrow, so it might be worth reaching out there.
Issue: When you select items in your Clipboard and then select the "Move" button, the heading of the page is not calculating the number of resources correctly.
Cause (I think): There are two Vuex modules contentNode and clipboard -- both of them keep "maps" (ie, an object mapping ids to the nodes). The id for nodes in the clipboard/clipboardNodesMap is not being loaded into the contentNode/contentNodesMap . The moveHeader is passing in the ids it gets from the clipboard Vuex module, which are used to look up the node's kind in the contentNode/contentNodesMap but... they're not there.
Some notes:
I hope this helps, thank you for taking this on!
radinamatic commentedon Aug 27, 2024
Still some hickups with how the folders/resources are calculated to display in the modal title: selected resources are always added into the count for folders. For example:
2 folders, 0 resources23 folders, 0 resourcesakolson commentedon Aug 27, 2024
cc @LianaHarris360
LianaHarris360 commentedon Aug 27, 2024
I believe I know why this is happening, I'll reopen this issue and get it sorted.
radinamatic commentedon Sep 5, 2024
Final manual QA on the
unstablebranch confirms the fix.