Sync node attributes does not work completely

[ivanistheone]

Summary

I want to sync nodes attributes between channel A and a derivative channel B.

Specifically I updated the exercises in the original channel were updated setting randomize=False, so I want to update the derivative channel to the same setting.

Expected:
After clicking SYNC the exercises int he derivative channel should have randomize=False.

Actual:
After clicking SYNC the exercises int he derivative channel continue to have randomize=True.

Category

Select one: BUG

Possible solution

I think we need a node.save() after this line
https://github.com/learningequality/studio/blob/develop/contentcuration/contentcuration/views/nodes.py#L795

[intelliant01]

@ivanistheone @jayoshih Not sure if this is the same problem wherein sync of topic and content meta-data also does not work between derivative and source channels. Had made title changes on the source topic and content nodes and even published them (though not required) , but none of them show up on the derivative channel despite having checked all boxes in the sync modal and hitting SYNC.
Only the main content (document, video, etc) sync seems to be working.

If this is not related then shall create another issue.

[rtibbles]

This is now fixed as extra_fields are now propagated, and saving happens at the appropriate time.