Migration guide: untouched fields, throws after dispose, reset, field streams, disposing subforms - #98
Merged
Conversation
The untouched-field gate, throws after dispose, reset keeping readOnly and the mode, addRelation as the port for field streams, and disposing a subform that is gone for good. In the checklist and in the sections. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
KamilSztandur
requested review from
PiotrRogulski and
mateusz-pietras
as code owners
September 28, 2026 11:51
|
Docs preview: https://advanced-forms-fc7xkjsoc-leancode.vercel.app Built from 84eb35c; the landing page is at |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
PiotrRogulski
approved these changes
Sep 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two ports from 0.1.x compiled fine and then surprised people at runtime, in the same five places. The guide either did not mention them or hid them in one sentence in the middle of a section:
setValueafter anawaitthrew on a screen that had closed;resetAll()left fields read-only and left the validation mode on;field.stream.distinct().listen(...)toaddListenerbrought back the old bug of reacting tomarkReadOnly();Solution
Each one gets a checklist item at the top of
MIGRATION.mdand a section with a before/after: the untouched-field gate with thevalidate()-from-a-listener recipe and its limits, the full list of what throws afterdispose()with theisDisposedguard,addRelationas the first port for a field stream, andremoveSubformplusdispose()for a section that is gone for good. The short copy on the website gets the same bullets.What it is like now
Someone porting an edit screen reads the checklist, finds "review
subscribeToFieldson prefilled fields" and "guard late writes", and does not spend an afternoon in the debugger.Design decisions
None in the package. The behaviours described are the ones 0.2.x already has, and the guide now says so up front. The listener recipe relies on the
validate()fix in #96, so this merges after it.🤖 Generated with Claude Code