Repository navigation
Conversation
…riant asyncio.iscoroutinefunction is deprecated since Python 3.14 and emits a DeprecationWarning at import/call time (laurentS#263). inspect.iscoroutinefunction is the drop-in replacement and is already used elsewhere in the codebase (middleware.py).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the two remaining
asyncio.iscoroutinefunction()calls inslowapi/extension.py(L720, L877) withinspect.iscoroutinefunction(), fixing theDeprecationWarningreported in #263.asyncio.iscoroutinefunctionis deprecated as of Python 3.14;inspect.iscoroutinefunctionis the documented drop-in replacement тАФ and it's already whatslowapi/middleware.pyuses, so this also makes the codebase consistent.Testing
6 failedfailures are pre-existing on master with current starlette versions and unrelated to this change тАФ same result with/without the patch, tracked separately in Incompatibility with recent Starlette versions (missing app.route) #271)import slowapi.extensionclean under Python 3.13Closes #263
Update: the
6 failedmentioned above were later traced to an unrelated float-epoch bug on master - fixed in #293, after which the suite is 103/103.