Repository navigation
Allow Laravel 12 - #8
Open
daryledesilva wants to merge 1 commit into
Open
daryledesilva wants to merge 1 commit into
daryledesilva wants to merge 1 commit into
Conversation
The 3.0.0 suite passes on Laravel 12.69 with Testbench 10 (548 passed, 1 skipped), except one route-order test: Laravel 13 lists routes with a domain first. No code change is needed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EqJysQYKx3uy3ABQBgNqCo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.0.0 requires Laravel 13.12, but nothing in it seems to need 13: the suite passes on Laravel 12 unchanged. This widens the constraint to
^12.0 || ^13.12, so apps still on 12 can use the generic--modulegenerators.Tested on Laravel 12.69.2, Testbench 10.12, Pest 4.7, PHP 8.4:
Conventions\RoutesTest > it applies every attribute…, which checks the order ofmoduleRoutes(). Laravel 13 lists routes with a domain first and 12 doesn't; the routes and their middleware are the same.module:make, then--moduleon the Laravel generators (model with a migration, migration, test, factory, enum) and on generators from other packages (philiprehberger/laravel-make-service's service, value, contract, dto and action; spatie/laravel-fractal's transformer). Every file landed in the module with the right namespace,migrate:statuslisted the module's migrations, andmodule:doctorfound no problems.I left the CI matrix and the dev constraints (Testbench
^11) alone. Happy to add a Laravel 12 job, or to skip that one route-order test on 12, if you'd like.🤖 Generated with Claude Code
https://claude.ai/code/session_01EqJysQYKx3uy3ABQBgNqCo