fix: parse comma-separated X-Forwarded-Proto in Scheme#3055
Open
sonnemusk wants to merge 1 commit into
Open
Conversation
Proxies may send multi-value X-Forwarded-Proto (e.g. "https, http"). The whole string failed isValidProto, so Scheme fell through incorrectly. Use the left-most valid token for X-Forwarded-Proto/Protocol and X-Url-Scheme.
Contributor
|
in which case that header has comma separated values? When I read https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Forwarded-Proto it only seems to refer single value |
Author
|
Agreed that MDN describes a single token. Multi-value
If you’d rather not support the multi-value case, I can close this and leave |
sonnemusk
force-pushed
the
fix/scheme-multi-value-forwarded-proto
branch
from
July 22, 2026 07:56
1305e35 to
4f38bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context.Scheme()treated the entireX-Forwarded-Protoheader as one token. Multi-proxy values likehttps, httpfailed validation and were ignored.Change
firstValidPrototo take the left-most valid scheme token.X-Forwarded-Proto,X-Forwarded-Protocol, andX-Url-Scheme.Test plan
go test . -run TestContext_Scheme