Repository navigation
Show MIDI CC number even for registered/named CCs. - #1200
Open
BuzzBurrowes wants to merge 1 commit into
Open
BuzzBurrowes wants to merge 1 commit into
BuzzBurrowes wants to merge 1 commit into
Conversation
JUCE's build in MidiMessage::getDescription() function does not include the CC number in the returned text if the CC number is a known/registered value. EG "Sound Control 8". This is not optimal in something like the MIDI Monitor node where you sometimes need to know the actual CC number being sent by your midi controller. This change is a small tweak to the MIDI Monitor node that assures the actual CC number is always shown even for registered CC numbers. EG... "Controller 77 - Sound Control 8: 100 channel 1" ... vs the original code... "Controller Sound Control 8: 100 channel 1"
Contributor
Author
|
It's fine if you don't want to take this one. It is a minor annoyance, and I am happy to keep the change local. But maybe others have this frustration as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JUCE's built in MidiMessage::getDescription() function does not include the CC number in the returned text if the CC number is a known/registered value. EG "Sound Control 8". This is not optimal in something like the MIDI Monitor node where you sometimes need to know the actual CC number being sent by your midi controller. This change is a small tweak to the MIDI Monitor node that assures the actual CC number is always shown even for registered CC numbers. EG...
"Controller 77 - Sound Control 8: 100 channel 1"
... vs the original code...
"Controller Sound Control 8: 100 channel 1"