Repository navigation
Wrong Github link in auto-generated README #952
Description
What happened (please include outputs or screenshots):
ref #931 (comment)
What you expected to happen:
the generated address should be git+https://github.com/kubernetes-client/python.git
How to reproduce it (as minimally and precisely as possible):
run scripts/update-client.sh, and see the link in kubernetes/README.md
Anything else we need to know?:
This has been happening since we graduated this repo from kubernetes-incubator/client-python to kubernetes-client/python
The link seems to be composed as
git+https://github.com/GIT_USER_ID/GIT_REPO_ID.git
according to https://github.com/swagger-api/swagger-codegen/blob/master/samples/client/petstore/python/README.md#pip-install
however, the IDs that we use in gen repo look reasonable: https://github.com/kubernetes-client/gen/blob/795993978f8563a9c09089993be4d2b97d492eec/openapi/python.xml#L22-L23
Environment:
- OS (e.g., MacOS 10.13.6): MacOS 10.14.6
- Python version (
python --version): 2.7.12 - Python client version (
pip list | grep kubernetes): master branch HEAD
Activity
palnabarun commentedon Oct 24, 2019
I investigated this issue. The problem seems to have a root in the following lines of codes in kubernetes-client/gen:openapi/python.sh
Reference: https://github.com/kubernetes-client/gen/blob/master/openapi/python.sh#L57-58
What is happening here is the first line replaces all instances of
clientwithkubernetes.client, and the second line replaces all wrongly replaced instances ofclient-pythonwith the correct string. The first line replaceskubernetes-client/pythonwithkubernetes-kubernetes.client/pythonresulting in the issue described above.One quick solution to this would be to add a line after the above code:
I believe a long term solution is make the string replacement is the README templates robust and removing the above hacks.
palnabarun commentedon Oct 24, 2019
/cc @roycaihw
palnabarun commentedon Oct 24, 2019
/assign
palnabarun commentedon Oct 24, 2019
Filed issue kubernetes-client/gen#133 to track this.
palnabarun commentedon Oct 24, 2019
Filed a PR kubernetes-client/gen#134 to resolve this.
palnabarun commentedon Nov 25, 2019
This issue has been fixed by kubernetes-client/gen#134. We should close this now maybe.
roycaihw commentedon Nov 26, 2019
Thanks for the fix!
/close
k8s-ci-robot commentedon Nov 26, 2019
@roycaihw: Closing this issue.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.